Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up user-facing strings to facilitate translation #158

Open
wants to merge 16 commits into
base: dev
Choose a base branch
from
Open

Clean up user-facing strings to facilitate translation #158

Changes from 1 commit
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
1752dae
Prepare to consolidate strings
JesseTG Jan 19, 2024
06e63ed
Move some strings to a new header
JesseTG Jan 20, 2024
e0e25a3
Prepare to consolidate strings
JesseTG Jan 19, 2024
7df0376
Move some strings to a new header
JesseTG Jan 20, 2024
bed29fc
Move user-facing OSD messages to `en_us.hpp`
JesseTG Jan 25, 2024
e23f8e9
Move more status messages to string constants
JesseTG Jan 25, 2024
100b9f2
Fix a compiler error
JesseTG Jan 25, 2024
302592c
Don't split that one sentene in the middle with an `#ifdef`
JesseTG Jan 25, 2024
c5991ee
Move more string literals to constants
JesseTG Jan 25, 2024
a502e8f
Merge remote-tracking branch 'origin/jtg/clean-up-strings' into jtg/c…
JesseTG Jan 30, 2024
b269c92
Split the strings into different header files
JesseTG Jan 30, 2024
360da8e
Move more string constants to the new headers
JesseTG Jan 30, 2024
f756b4d
Merge branch 'main' into jtg/clean-up-strings
JesseTG Feb 13, 2024
bcdf492
Move some newly-introduced strings to the header files
JesseTG Feb 13, 2024
d7a8a7b
Use named format arguments for user-facing strings
JesseTG Feb 14, 2024
8fb17f8
Merge branch 'dev' into jtg/clean-up-strings
JesseTG Feb 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Don't split that one sentene in the middle with an #ifdef
  • Loading branch information
@JesseTG
JesseTG committed Jan 30, 2024
commit 302592cc8f6e6cc6063ccdcb8421248f9b358a3c
13 changes: 7 additions & 6 deletions src/libretro/config/definitions/network.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,12 +31,13 @@ namespace MelonDsDs::config::definitions {
"Indirect: Use libslirp to emulate the DS's network stack. Simple and needs no setup.\n"
#ifdef HAVE_NETWORKING_DIRECT_MODE
"Direct: Routes emulated Wi-Fi packets to the host's network interface. "
"Faster and more reliable, but requires an ethernet connection and "
#ifdef _WIN32
"that WinPcap or Npcap is installed. "
#else
"that libpcap is installed. "
#endif
# ifdef _WIN32
"Faster and more reliable, but requires an ethernet connection "
"and that WinPcap or Npcap is installed. "
# else
"Faster and more reliable, but requires an ethernet connection "
"and that libpcap is installed. "
# endif
"If unavailable, falls back to Indirect mode.\n"
#endif
"\n"
Expand Down