Skip to content

Commit

Permalink
Fixed merging of PR's, added spacing to toolTipUnit and fixed some …
Browse files Browse the repository at this point in the history
…JSHint errors
  • Loading branch information
Darragh Kirwan committed May 15, 2016
1 parent 03240ff commit 7326649
Showing 1 changed file with 12 additions and 5 deletions.
17 changes: 12 additions & 5 deletions src/calendar-heatmap.js
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@ function calendarHeatmap() {
var data = [];
var colorRange = ['#D8E6E7', '#218380'];
var tooltipEnabled = true;
var tooltipUnit = 'contributions';
var legendEnabled = true;
var onClick = null;

Expand Down Expand Up @@ -43,6 +44,12 @@ function calendarHeatmap() {
return chart;
};

chart.tooltipUnit = function (value) {
if (!arguments.length) { return tooltipUnit; }
tooltipUnit = value;
return chart;
};

chart.legendEnabled = function (value) {
if (!arguments.length) { return legendEnabled; }
legendEnabled = value;
Expand Down Expand Up @@ -110,8 +117,8 @@ function calendarHeatmap() {
.append('div')
.attr('class', 'day-cell-tooltip')
.html(tooltipHTMLForDate(d))
.style('left', function () { return Math.floor(i / 7) * SQUARE_LENGTH; })
.style('top', function () { return d.getDay() * (SQUARE_LENGTH + SQUARE_PADDING) + MONTH_LABEL_PADDING * 3; });
.style('left', function () { return Math.floor(i / 7) * SQUARE_LENGTH + 'px'; })
.style('top', function () { return d.getDay() * (SQUARE_LENGTH + SQUARE_PADDING) + MONTH_LABEL_PADDING * 3 + 'px'; });
})
.on('mouseout', function (d, i) {
tooltip.remove();
Expand Down Expand Up @@ -184,7 +191,7 @@ function calendarHeatmap() {
function tooltipHTMLForDate(d) {
var dateStr = moment(d).format('ddd, MMM Do YYYY');
var count = countForDate(d);
return '<span><strong>' + (count ? count : 'No') + ' contribution' + (count === 1 ? '' : 's') + '</strong> on ' + dateStr + '</span>';
return '<span><strong>' + (count ? count : 'No') + ' ' + tooltipUnit + (count === 1 ? '' : 's') + '</strong> on ' + dateStr + '</span>';
}

function countForDate(d) {
Expand All @@ -198,10 +205,10 @@ function calendarHeatmap() {
return count;
}

var daysOfChart = chart.data().map(function (day){
// use moment to formt it to Do MM YYYY
var daysOfChart = chart.data().map(function (day) {
return day.date.toDateString();
});

dayRects.filter(function (d) {
return daysOfChart.indexOf(d.toDateString()) > -1;
}).attr('fill', function (d, i) {
Expand Down

0 comments on commit 7326649

Please sign in to comment.