Gui - added Wifi connection failed message #33
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gui - added lost Signal K connection message WifiManager - added log with disconnected reason (for debuging) WifiManager - added detection for Wifi assoc failure and sending Gui message to inform user WifiManager - there was a bug that caused incorrect cleanup of Wifi resources that could cause battery drain WifiManager - Wifi will be added to know list only if connection is success! WifiManager - connect function will correctly disable wifi before new connection SignalKSocket - added reconnect counter that will stop reconnecting websocket after 3 attempts SignalKSocket - raised incomming JSON buffer size to 4K, moved delta_counter to parse_data SoundPlayer - some basic stuff - not working yet (networking is priority now) Keyboard - removed callback events log SettingsView - added const int spacing to make object spacing same on every view Signal K settings - if connected to SK show number of parsed deltas WifiSettings - layout change to make Connect and Scan buttons centered, added enhanced update checking
|
@ba58smith any notes from your side? Thanks! |
|
No comments here, except that all those changes and fixes look great! I will try it all as soon as I can after you merge it. Hopefully tomorrow. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Been playing with Wifi and SK connections lately and fixed few more bugs and added more messages into GUI to let user know what is going on.
Things I've changed:
Gui - added lost Signal K connection message
WifiManager - added log with disconnected reason (for debuging)
WifiManager - added detection for Wifi assoc failure and sending Gui message to inform user
WifiManager - there was a bug that caused incorrect cleanup of Wifi resources that could cause battery drain
WifiManager - Wifi will be added to know list only if connection is success!
WifiManager - connect function will correctly disable Wifi before new connection
SignalKSocket - added reconnect counter that will stop reconnecting websocket after 3 attempts
SignalKSocket - raised incomming JSON buffer size to 4K, moved delta_counter to parse_data
SoundPlayer - some basic stuff - not working yet (networking is priority now)
Keyboard - removed callback events log
SettingsView - added const int spacing to make object spacing same on every view
Signal K settings - if connected to SK show number of parsed deltas
WifiSettings - layout change to make Connect and Scan buttons centered, added enhanced update checking