Double-tap to switch between LIGHT and DARK themes #43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It works, but it happens on ALL screens. Any screen with a button (even the "Back" button in the upper left corner) will not look right after a theme change if you do the double-tap on that screen. We need to either make the double-tap work ONLY on the home screen, or we need a way to update all the buttons and icons on every screen if you double-tap on it to change the theme.
This makes the double-tap (which changes from LIGHT to DARK or vice versa) work properly on any screen. There are also some general code clean-up changes, and a few bug fixes. Still need to make the double-tap theme change be saved to disk. Now, that works only if you happen to do the double-tap on the Display Settings screen.
Also, remove some debugging code, and update some comments.
|
I still want to save the theme change that's brought on by a double-tap, so don't merge yet. |
…ys active when awake
ba58smith
changed the title
|
Everything is working now, but there is one enhancement I can make if you think I should, @JohnySeven. If you're on the Wakeup Settings page, and you disable double-tap wakeup, the double-tap theme switch doesn't work until the next time the watch wakes up. I don't think this is a problem, because if you can see the screen well enough to get to the Wakeup Settings page, and disable the double-tap wakeup, you probably don't need to do the double-tap to switch the screen. You agree? |
|
@ba58smith I'm OK with that, good job! Will test it and merge it! Thanks! :-) |
|
Looking nice, thanks @ba58smith! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It works, but it happens on ALL screens. Any screen with a button (even the "Back" button in the upper left corner) will not look right after a theme change if you do the double-tap on that screen.
We need to either make the double-tap work ONLY on the home screen, or we need a way to update all the buttons and icons on every screen if you double-tap on it to change the theme.
I also made a few unrelated changes - fixed some typos, mostly.