Status bar refactoring #66
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I've made the statusbar more object based, more capable. Every status bar icon (image or text) now have object representation that can be used to manipulate icon status (visible, hidden, warning), color (setcolor) and text (in case of text status).
This commit is good for studying how to add new status bar icon and update it's state.
ba58smith
reviewed
Jul 3, 2021
src/ui/statusbar.h
Outdated
| { | ||
| if (status_ != status) | ||
| { | ||
| auto call_update = (status == StatusBarIconStatus::Hidden || status_ == StatusBarIconStatus::Hidden); |
There was a problem hiding this comment.
This is the first time I've seen this: using auto instead of bool for a boolean variable. Is that something new - using auto as much as possible?
There was a problem hiding this comment.
Yeah, C# makes my coding style too lazy. Will change it to bool as it's really not required to use auto in here. Thanks
|
Wow! What a lot of work for just the icons!!! But I'm glad you did it - it will make it much easier to do anything with icons in the future. I didn't review every line - it was too much for my brain. And I had only one question - about style, not substance. I'm sure you've tested it, and we'll find out soon enough if it's not working correctly. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've made the statusbar more object based, more capable. Every status bar icon (image or text) now have object representation that can be used to manipulate icon status (visible, hidden, warning), color (setcolor) and text (in case of text status).
Last commit contains adding new status icon - number of pending messages from SK server or warning messages about SK connection or Wifi.