Skip to content

Commit

Permalink
Rename some commands in the firefox driver to prepare for selenium 3.
Browse files Browse the repository at this point in the history
This essentially means that we're mirroring the names of the commands in the
function names within the driver.
  • Loading branch information
shs96c committed Mar 20, 2014
1 parent ff40c27 commit 10cc303
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 6 deletions.
6 changes: 3 additions & 3 deletions javascript/firefox-driver/js/dispatcher.js
Original file line number Diff line number Diff line change
Expand Up @@ -261,11 +261,11 @@ Dispatcher.prototype.init_ = function() {
this.bind_('/session/:sessionId/element/:id/click').
on(Request.Method.POST, Dispatcher.executeAs('clickElement'));
this.bind_('/session/:sessionId/moveto').
on(Request.Method.POST, Dispatcher.executeAs('mouseMove'));
on(Request.Method.POST, Dispatcher.executeAs('mouseMoveTo'));
this.bind_('/session/:sessionId/buttondown').
on(Request.Method.POST, Dispatcher.executeAs('mouseDown'));
on(Request.Method.POST, Dispatcher.executeAs('mouseButtonDown'));
this.bind_('/session/:sessionId/buttonup').
on(Request.Method.POST, Dispatcher.executeAs('mouseUp'));
on(Request.Method.POST, Dispatcher.executeAs('mouseButtonUp'));
this.bind_('/session/:sessionId/click').
on(Request.Method.POST, Dispatcher.executeAs('mouseClick'));
this.bind_('/session/:sessionId/doubleclick').
Expand Down
6 changes: 3 additions & 3 deletions javascript/firefox-driver/js/firefoxDriver.js
Original file line number Diff line number Diff line change
Expand Up @@ -1075,7 +1075,7 @@ FirefoxDriver.prototype.sendResponseFromSyntheticMouse_ = function(mouseReturnVa
}
};

FirefoxDriver.prototype.mouseMove = function(respond, parameters) {
FirefoxDriver.prototype.mouseMoveTo = function(respond, parameters) {
// Coordinate spaces in use:
// * Owner document space: Coordinates are relative to the top-left of the
// top-level document contained by the window handle containing the
Expand Down Expand Up @@ -1198,7 +1198,7 @@ FirefoxDriver.prototype.mouseMove = function(respond, parameters) {
}
};

FirefoxDriver.prototype.mouseDown = function(respond, parameters) {
FirefoxDriver.prototype.mouseButtonDown = function(respond, parameters) {
var doc = respond.session.getDocument();

if (!this.enableNativeEvents) {
Expand Down Expand Up @@ -1236,7 +1236,7 @@ FirefoxDriver.prototype.mouseDown = function(respond, parameters) {
respond.send();
};

FirefoxDriver.prototype.mouseUp = function(respond, parameters) {
FirefoxDriver.prototype.mouseButtonUp = function(respond, parameters) {
var doc = respond.session.getDocument();

if (!this.enableNativeEvents) {
Expand Down

0 comments on commit 10cc303

Please sign in to comment.