Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All the
bevy_xpbd
components I'm using implementPartialEq
except forCollider
.Having
PartialEq
is really useful for various netcode bits that check what's changed in generic systems.Collider
is a wrapper over parry'sSharedShape
, and not all parryShape
s implementPartialEq
For those that do, i'm using it. For the rest, i'm comparing what is necessary manually – eg, border radius for rounded versions of shapes.
I took the big match on shape types from the implementation of
fmt::Debug
forCollider
, soPartialEq
will work for all the same shapes.