Add #[reflect(Serialize, Deserialize)] and register more types
#395
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
janhohenheim
suggested changes
Jul 3, 2024
Co-authored-by: Jan Hohenheim <jan@hohenheim.ch>
janhohenheim
approved these changes
Jul 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
Updated version of #351.
A lot of types are missing
ReflectSerializeandReflectDeserializeimplementations with theserializefeature enabled, and several types are also not registered in theTypeRegistry.Solution
Add
#[cfg_attr(feature = "serialize", reflect(Serialize, Deserialize)]for types that were missing it, and register more types in thePhysicsTypeRegistrationPlugin. I also fixed and added some other derives, including removingComponentfromCoefficientCombine.Migration Guide
CoefficientCombineis no longer a component. It was never supposed to be one, and did nothing on an entity anyways.