Skip to content

Commit

Permalink
Update config_spec.md
Browse files Browse the repository at this point in the history
Remove `evaluation_units` from mandatory fields in EVALUATION section

This field is actually in application SEGMENTATION field, as shown in the source 
code https://github.com/NifTK/NiftyNet/blob/cfee80aa76c333ccfce434e2e1e6eee704b7205c/niftynet/evaluation/segmentation_evaluations.py#L48. The args that get parsed is `self.app_param` instead of `self.eval_param`
  • Loading branch information
patrick-llgc committed Jan 22, 2019
1 parent e180edd commit bc3f478
Showing 1 changed file with 5 additions and 0 deletions.
5 changes: 5 additions & 0 deletions doc/source/config_spec.md
Original file line number Diff line number Diff line change
Expand Up @@ -718,8 +718,13 @@ The evaluation configuration section (`[EVALUATION]`) must contain:
[regression evaluations](./niftynet.evaluation.regression_evaluations.html),
[segmentation evaluations](./niftynet.evaluation.segmentation_evaluations.html),
and [classification evaluations](./niftynet.evaluation.classification_evaluations.html).

Note that application specific configuration (such as `evaluation_units`) are specified
in the application configuration section (such as `[SEGMENTATION]`).
<!---
- `evaluation_units` -- `foreground`, `label` or `cc`. Describe how the
evaluation should be performed in the case of segmentation mostly
(`foreground` means only one label, `label` means metrics per label, `cc`
means metrics per connected component). More on this topic can be found at
[segmentation evaluations](./niftynet.evaluation.segmentation_evaluations.html).
-->

0 comments on commit bc3f478

Please sign in to comment.