Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HalogenHooks recipes are broken on TryPureScript #279

Closed
pete-murphy opened this issue Jul 14, 2021 · 6 comments
Closed

HalogenHooks recipes are broken on TryPureScript #279

pete-murphy opened this issue Jul 14, 2021 · 6 comments
Labels
fix-recipe Indicates a broken recipe that needs to be updated to work again

Comments

@pete-murphy
Copy link
Collaborator

Recipe Name

*HalogenHooks

Reason for Breakage / Steps to Fix

I think all the *HalogenHooks are currently broken on TryPureScript because of the mismatch of Halogen versions. Seems like a lot of them could be fixed by removing HH.HTML as the first argument to Component (which now just takes four type parameters: https://pursuit.purescript.org/packages/purescript-halogen/6.1.2/docs/Halogen#t:Component), and removing Just from some of the event handlers (Halogen.HTML.Event.onClick for example now takes MouseEvent -> i not MouseEvent -> Maybe i: https://pursuit.purescript.org/packages/purescript-halogen/6.1.2/docs/Halogen.HTML.Events#v:onClick)

@pete-murphy pete-murphy added the fix-recipe Indicates a broken recipe that needs to be updated to work again label Jul 14, 2021
@pete-murphy
Copy link
Collaborator Author

I'm not well-versed in Halogen, but I think I can at least fix the trivially-fixable ones and mark the rest as broken. I'll plan on having a PR sometime this week.

@JordanMartinez
Copy link
Owner

Yeah, one of the breaking changes in Halogen was dropping the surface type parameter, so that's what's causing a lot of the breakage here.

@thomashoneyman
Copy link

Those two changes should fix everything except for any recipes that rely on event sources, as those have also changed in Halogen 6 (to become simpler!).

@pete-murphy
Copy link
Collaborator Author

pete-murphy commented Jul 15, 2021

I've started down the road of bumping PureScript to 0.14.3 and the package set to latest: #280. I'm not sure if there's a better alternative to resolving this, but so far the breakages haven't been too bad, and there might be trivial fixes for some of those I've marked as broken (I haven't looked into the breaking changes related to Hooked, but those seem like might be easily resolved). I would plan on doing a second pass on the broken/* recipes before submitting PR for review.

I can probably get to the rest sometime this week, if this would be a welcome change. If there's an alternative that's more minimal I could look into that instead.

@JordanMartinez
Copy link
Owner

Thanks! Yes, this would be a desired change. Even if we only get some of this updated, that's better than none of it. This repo was designed to account for that possible situation.

@pete-murphy
Copy link
Collaborator Author

Resolved by #280

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix-recipe Indicates a broken recipe that needs to be updated to work again
Projects
None yet
Development

No branches or pull requests

3 participants