Bump PureScript to 0.14.3 #280

pete-murphy · 2021-07-15T04:41:56Z

All told, only 17 14 of 80 ended up in the broken pile which doesn't seem too bad.

AceEditorHalogenHooks
❌ Move to broken

Module Halogen.Query.EventSource was not found.

Add RemoveEventListenerJs
✏️ Add missing dependencies to spago.dhall

AffGameSnakeJs
❌ Move to broken

[error] The following packages do not exist in your package set:
[error]   - canvas-action
[error]   - game

AffjaxPostNode
✏️ Add missing dependencies to spago.dhall
BasicHalogenHooks
✏️ Remove HH.HTML as parameter to Component
✏️ Update event handler signature from MouseEvent -> Maybe i to MouseEvent -> i

BehaviorSuperCircleJs
❌ Move to broken

[error] The following packages do not exist in your package set:
[error]   - behaviors

BigIntJs
✅ Already works
BookHalogenHooks
✏️ Remove HH.HTML as parameter to Component
BookReactHooks
✅ Already works
ButtonsHalogenHooks
✏️ Remove HH.HTML as parameter to Component
✏️ Update event handler signature from MouseEvent -> Maybe i to MouseEvent -> i
ButtonsReactHooks
✅ Already works
CapabilityPatternNode
✅ Already works
CardsHalogenHooks
✏️ Remove HH.HTML as parameter to Component
✏️ Update event handler signature from MouseEvent -> Maybe i to MouseEvent -> i
✏️ Change NonEmpty Array to NonEmptyArray
CardsReactHooks
✏️ Change NonEmpty Array to NonEmptyArray
CatGifsHalogenHooks
✏️ Remove HH.HTML as parameter to Component
✏️ Update event handler signature from MouseEvent -> Maybe i to MouseEvent -> i
CatGifsReactHooks
✅ Already works
ClockReactHooks
✅ Already works

ComponentsHalogenHooks
❌ Move to broken

Cannot import type Hooked from module Halogen.Hooks
It either does not exist or the module does not export it.

ComponentsInputHalogenHooks
❌ Move to broken

Cannot import type Hooked from module Halogen.Hooks
It either does not exist or the module does not export it.

ComponentsInputReactHooks
✅ Already works

ComponentsMultiTypeHalogenHooks
❌ Move to broken

Cannot import type Hooked from module Halogen.Hooks
It either does not exist or the module does not export it.

ComponentsMultiTypeReactHooks
✅ Already works
ComponentsReactHooks
✅ Already works
DateTimeBasicsLog
✅ Already works
DebuggingLog
✏️ Change Debug.Trace to Debug
DiceCLI
✏️ Switch argument order
DiceLog
✅ Already works
DragAndDropHalogenHooks
✏️ Remove HH.HTML as parameter to Component
✏️ Update event handler signature from MouseEvent -> Maybe i to MouseEvent -> i
DragAndDropReactHooks
✅ Already works

DriverIoHalogenHooks
❌ Move to broken

Module Control.Coroutine was not found.

DriverRoutingHalogenHooks
❌ Move to broken

Could not match type

  Function t1

with type

  Proxy @Symbol

DriverWebSocketsHalogenHooks
❌ Move to broken

Could not match type

  Function t1

with type

  Proxy @Symbol

FileUploadHalogenHooks
✏️ Remove HH.HTML as parameter to Component
✏️ Update event handler signature from MouseEvent -> Maybe i to MouseEvent -> i
FileUploadReactHooks
✅ Already works
FindDomElementJs
✅ Already works
FormsReactHooks
✅ Already works
GroceriesHalogenHooks
✏️ Remove HH.HTML as parameter to Component
GroceriesJs
✏️ appendChild returns Unit instead of Node
GroceriesReactHooks
✅ Already works
HelloConcur
✅ Already works
HelloHalogenHooks
✏️ Remove HH.HTML as parameter to Component
HelloJs
✅ Already works
HelloLog
✅ Already works
HelloReactHooks
✅ Already works
HeterogenousArrayLog
✏️ Replace SProxy with Proxy
ImagePreviewsHalogenHooks
✏️ Remove HH.HTML as parameter to Component
✏️ Update event handler signature from MouseEvent -> Maybe i to MouseEvent -> i
ImagePreviewsReactHooks
✅ Already works
InterpretHalogenHooks
✏️ Remove HH.HTML as parameter to Component
✏️ Update event handler signature from MouseEvent -> Maybe i to MouseEvent -> i

KeyboardInputHalogenHooks
❌ Move to broken

Module Halogen.Query.EventSource was not found.

LifecycleHalogenHooks
✏️ Remove HH.HTML as parameter to Component
✏️ Update event handler signature from MouseEvent -> Maybe i to MouseEvent -> i
✏️ Replace SProxy with Proxy

MemoizeFibonacci
❌ Move to broken

[error] The following packages do not exist in your package set:
[error]   - memoize

NumbersHalogenHooks
✏️ Remove HH.HTML as parameter to Component
✏️ Update event handler signature from MouseEvent -> Maybe i to MouseEvent -> i
NumbersReactHooks
✅ Already works
ParallelAppMExampleLog
✅ Already works
PayloadHttpApiNode
✅ Already works
PositionsHalogenHooks
✏️ Remove HH.HTML as parameter to Component
✏️ Update event handler signature from MouseEvent -> Maybe i to MouseEvent -> i
PositionsReactHooks
✅ Already works
RandomNumberGameNode
✅ Already works
ReadPrintFileContentsConcur
✅ Already works
ReadPrintFileContentsNode
✅ Already works

RoutingHashHalogenClassic
❌ Move to broken

Could not match type

  Function t1

with type

  Proxy @Symbol

RoutingHashLog
✏️ Remove generics-rep from spago.dhall
✏️ Replace Data.Generic.Rep.Show with Data.Show.Generic
RoutingHashReactHooks
✏️ Remove generics-rep from spago.dhall

RoutingPushHalogenClassic
❌ Move to broken

Could not match type

  Function t1

with type

  Proxy @Symbol

RoutingPushReactHooks
✏️ Remove generics-rep from spago.dhall
RunCapabilityPatternNode
✏️ Update usage of Run
ShapesHalogenHooks
✏️ Update to reflect a few breaking changes in Halogen.Svg.Attributes
ShapesReactHooks
✅ Already works
SignalRenderJs
✅ Already works
SignalSnakeJs
✅ Already works
SignalTrisJs
✏️ Use toMap from Data.Set
✏️ Remove toNonEmpty
SimpleASTParserLog
✏️ Replace Global import with qualified Data.Number import
TextFieldsHalogenHooks
✏️ Remove HH.HTML as parameter to Component
✏️ Update event handler signature from MouseEvent -> Maybe i to MouseEvent -> i
TextFieldsReactHooks
✅ Already works
TicTacToeReactHooks
✏️ Remove generics-rep from spago.dhall
✏️ Replace Data.Generic.Rep.Show with Data.Show.Generic

TimeHalogenHooks
❌ Move to broken

Module Halogen.Query.EventSource was not found.

TimeReactHooks
✅ Already works
ValueBasedJsonCodecLog
✏️ Replace partial fromRight with inline lambda
WindowPropertiesJs
✅ Already works
WriteFileNode
✅ Already works

JordanMartinez · 2021-07-15T14:04:57Z

Thanks for working on this!

pete-murphy · 2021-07-16T03:19:39Z

recipes/ValueBasedJsonCodecLog/src/Main.purs

 exampleJson :: Json
-exampleJson = unsafePartial $ fromRight $ jsonParser
+exampleJson = unsafePartial $ (\(Right json) -> json) $ jsonParser


fromRight is no longer a partial function https://pursuit.purescript.org/packages/purescript-either/5.0.0/docs/Data.Either#v:fromRight

I considered making a standalone function for this, something like

fromRight :: Partial => forall a b. Either a b -> b fromRight (Right x) = x

but I opted for the minimal change. I'm definitely open to suggestions here; this one in particular felt like one of the more questionable changes.

I think people have typically been doing something like either (\_ -> unsafeCrashWith "got Left: bad parser") identity. It's a bit longer, but then it at least provides a somewhat clearer error message.

pete-murphy · 2021-07-16T03:21:11Z

recipes/SimpleASTParserLog/src/Main.purs

-      case readFloat fullString of
-        x | isFinite x -> pure $ LitNum x
+      case Number.fromString fullString of
+        Just x | Number.isFinite x -> pure $ LitNum x


Couldn't find the partial readFloat here, so replaced with fromString. Since there was already a fromString imported from Data.Int, I had to namespace both imports to disambiguate.

The Number.isFinite check is no longer necessary as Number.fromString already handles that.

JordanMartinez · 2021-07-16T04:59:41Z

Argument order was switched in node-readline#23:
- DiceCLI
FProxy was replaced with Proxy
- RunCapabilityPatternNode
Map's Monoid instance was dropped. Use SemigroupMap newtype to get instance again, but check the k's Monoid instance to verify that implementation is still the same:
- SignalTrisJs

Don't worry about these ones:

Needs to update code to use new EventSource code
- AceEditorHalogenHooks - repo example
- DriverIoHalogenHooks - repo example
- DriverWebSocketsHalogenHooks - repo example
- KeyboardInputHalogenHooks -
- TimeHalogenHooks
Hooked type missing from Halogen.Hooks module. declaration of hook and the function that creates/uses it
- ComponentsHalogenHooks
- ComponentsInputHalogenHooks
- ComponentsMultiTypeHalogenHooks
slot_ was changed
- DriverRoutingHalogenHooks
- RoutingHashHalogenClassic
- RoutingPushHalogenClassic

Can't do anything about these ones other than get the packages added again to the package set:

Packages missing from package set.
- canvas-action, game
  - AffGameSnakeJs
- behaviors
  - BehaviorSuperCircleJs
- memoize
  - MemoizeFibonacci

pete-murphy · 2021-07-16T05:05:17Z

* Argument order was switched in [node-readline#23](https://github.com/purescript-node/purescript-node-readline/pull/23/files):
  
  * DiceCLI

* `FProxy` was replaced with `Proxy`
  
  * RunCapabilityPatternNode

* `Map`'s `Monoid` instance was dropped. Use [`SemigroupMap`](https://pursuit.purescript.org/packages/purescript-ordered-collections/2.0.1/docs/Data.Map#t:SemigroupMap) newtype to get instance again, but check the `k`'s `Monoid` instance to verify that implementation is still the same:
  
  * SignalTrisJs

Sounds good 👍 those seem reasonable enough to tackle in this PR

JordanMartinez · 2021-07-16T05:27:00Z

Thanks again for all this work!

pete-murphy · 2021-07-16T13:29:38Z

recipes/RunCapabilityPatternNode/src/Application.purs

-type LOGGER = FProxy LoggerF
-type GET_USER_NAME = FProxy GetUserNameF
+type LOGGER r = (logger :: LoggerF | r)
+type GET_USER_NAME r = (getUserName :: GetUserNameF | r)


This compiles and works, but I was just guessing my way through this refactor while referencing the Run docs. There might be an alternative that's closer to the original.

pete-murphy · 2021-07-16T13:32:48Z

recipes/SignalTrisJs/src/Main.purs

 -----------------
-- Faster versions of these functions are proposed in
-- https://github.com/purescript/purescript-ordered-collections/pull/21
-toMap :: forall a. Ord a => Set a -> Map a Unit
-toMap = foldl (\m k -> Map.insert k unit m) mempty
-
 annotateSet :: forall a b. Ord a => (a -> b) -> Set a -> Map a b
 annotateSet f = mapWithIndex (\k _ -> f k) <<< toMap


toMap is now in Data.Set, so no need for a Monoid instance here. I couldn't find anything like annotateSet in there though.

Just added annotateSet to the todo list in purescript/purescript-ordered-collections#50
Might be good to link to that new issue in a comment here.

JordanMartinez · 2021-07-16T13:48:19Z

package.json

-    "purescript": "^0.13.8",
-    "spago": "^0.16.0"
+    "purescript": "^0.14.3",
+    "spago": "^0.19.1"


We'll want to bump this to the latest spago version, but that should be done in a separate PR.

JordanMartinez

Changes to make before merging this:

Let's change migrate from the fromRight partial function to ~~either (\_ -> unsafeCrashWith "got Left: bad parser") identity~~ fromRight' (\_ -> unsafeCrashWith "got Left: bad parser").
Check whether v0.14.3 compiles this PR too (if it does, use it; if not, ignore it and continue with the one you have).

Thank you for all your work!

pete-murphy · 2021-07-16T14:05:32Z

* [ ]  Let's change migrate from the `fromRight` partial function to `either (\_ -> unsafeCrashWith "got Left: bad parser") identity`.

I think

either (\_ -> unsafeCrashWith "got Left: bad parser") identity

is same as

fromRight' \_ -> unsafeCrashWith "got Left: bad parser"

I'm fine with either (no pun intended) but would you still prefer the former?

JordanMartinez · 2021-07-16T14:07:42Z

Oh, whoops! Yeah, let's use the fromRight' \_ -> ... version.

pete-murphy · 2021-07-16T15:00:13Z

make buildAll works with the 0.14.3 package set 👍

JordanMartinez · 2021-07-17T13:35:55Z

I'm going to use a merge commit for this PR because it touches so many different recipes.

pete-murphy added 20 commits July 14, 2021 22:18

Bump package-set, nix

9b59c3e

Fix AddRemoveEventListenerJs

eeac3d8

Mark AffGameSnakeJs as broken

d7776f1

Bump spago and purescript in package.json

d7976c1

Fix AffjaxPostNode

bb7e834

Fix BasicHalogenHooks

7b0616d

Move BehaviorSuperCircleJs to broken

9ef4b66

Fix BookHalogenHooks

8a22974

Fix ButtonsHalogenHooks

67e6763

Fix CardsHalogenHooks

3f788c4

Fix CardsReactHooks

fa25af3

Fix CatGifsHalogenHooks

f9fbe52

Move ComponentsHalogenHooks to broken

b74b54c

Move ComponentsInputHalogenHooks to broken

124b100

Move ComponentsMultiTypeHalogenHooks to broken

5d981c8

Fix DebuggingLog

2a16ed3

Move DiceCLI to broken

a438b8d

Fix DragAndDropHalogenHooks

c34e7a4

Move AceEditorHalogenHooks to broken

93cab2d

Move DriverIoHalogenHooks to broken

b1ae181

pete-murphy mentioned this pull request Jul 15, 2021

HalogenHooks recipes are broken on TryPureScript #279

Closed

pete-murphy added 8 commits July 15, 2021 20:45

Move DriverRoutingHalogenHooks to broken

d8c2fa8

Move DriverWebSocketsHalogenHooks to broken

2c150c9

Fix FileUploadHalogenHooks

d68ccea

Fix GroceriesHalogenHooks

218b5fe

Fix GroceriesJs

d020f61

Fix HelloHalogenHooks

a52a771

Fix HeterogenousArrayLog

a15a6b4

Fix ImagePreviewsHalogenHooks

ea7d999

Update README

18fe681

pete-murphy force-pushed the pm/bump-purescript-0-14-3 branch from 6594118 to 18fe681 Compare July 16, 2021 03:12

pete-murphy commented Jul 16, 2021

View reviewed changes

pete-murphy marked this pull request as ready for review July 16, 2021 03:21

pete-murphy added 2 commits July 16, 2021 00:45

Remove isFinite check

0668a5d

Remove trailing whitespace

b5bba08

pete-murphy added 5 commits July 16, 2021 08:41

Fix DiceCLI

6944b21

Fix RunCapabilityPatternNode

501f219

Fix SignalTrisJs

0f5231e

Fix inconsistent whitespace in RunCapabilityPatternNode

4595647

Update README

5653c67

pete-murphy commented Jul 16, 2021

View reviewed changes

JordanMartinez reviewed Jul 16, 2021

View reviewed changes

JordanMartinez approved these changes Jul 16, 2021

View reviewed changes

pete-murphy added 3 commits July 16, 2021 10:41

Use fromRight' instead of lambda

a1f97fe

Upgrade package-set

4848fb1

Remove unsafePartial

c1f12c8

Add comment about annotateSet

1616b74

JordanMartinez merged commit a69f835 into JordanMartinez:master Jul 17, 2021

pete-murphy deleted the pm/bump-purescript-0-14-3 branch July 17, 2021 22:30

pete-murphy mentioned this pull request Jul 18, 2021

Restore broken Components*HalogenHooks recipes #283

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Bump PureScript to 0.14.3 #280

Bump PureScript to 0.14.3 #280

pete-murphy commented Jul 15, 2021 •

edited

Loading

JordanMartinez commented Jul 15, 2021

pete-murphy Jul 16, 2021

pete-murphy Jul 16, 2021

JordanMartinez Jul 16, 2021

pete-murphy Jul 16, 2021

pete-murphy Jul 16, 2021

JordanMartinez Jul 16, 2021

pete-murphy Jul 16, 2021

JordanMartinez commented Jul 16, 2021

pete-murphy commented Jul 16, 2021

JordanMartinez commented Jul 16, 2021

pete-murphy Jul 16, 2021 •

edited

Loading

pete-murphy Jul 16, 2021 •

edited

Loading

milesfrain Jul 16, 2021 •

edited

Loading

pete-murphy Jul 16, 2021

JordanMartinez Jul 16, 2021

JordanMartinez left a comment •

edited by pete-murphy

Loading

pete-murphy commented Jul 16, 2021

JordanMartinez commented Jul 16, 2021

pete-murphy commented Jul 16, 2021

JordanMartinez commented Jul 17, 2021

Bump PureScript to 0.14.3 #280

Bump PureScript to 0.14.3 #280

Conversation

pete-murphy commented Jul 15, 2021 • edited Loading

JordanMartinez commented Jul 15, 2021

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

JordanMartinez commented Jul 16, 2021

pete-murphy commented Jul 16, 2021

JordanMartinez commented Jul 16, 2021

pete-murphy Jul 16, 2021 • edited Loading

Choose a reason for hiding this comment

pete-murphy Jul 16, 2021 • edited Loading

Choose a reason for hiding this comment

milesfrain Jul 16, 2021 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

JordanMartinez left a comment • edited by pete-murphy Loading

Choose a reason for hiding this comment

pete-murphy commented Jul 16, 2021

JordanMartinez commented Jul 16, 2021

pete-murphy commented Jul 16, 2021

JordanMartinez commented Jul 17, 2021

pete-murphy commented Jul 15, 2021 •

edited

Loading

pete-murphy Jul 16, 2021 •

edited

Loading

pete-murphy Jul 16, 2021 •

edited

Loading

milesfrain Jul 16, 2021 •

edited

Loading

JordanMartinez left a comment •

edited by pete-murphy

Loading