Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Re-enable the 'try' link for browser-based recipes #293

Closed
JordanMartinez opened this issue Jul 16, 2022 · 2 comments · Fixed by #295
Closed

Re-enable the 'try' link for browser-based recipes #293

JordanMartinez opened this issue Jul 16, 2022 · 2 comments · Fixed by #295
Labels
cookbook Issues related to this repo as a whole and not a recipe in particular

Comments

@JordanMartinez
Copy link
Owner

In #292, we disabled the try links because there are still some issues with Try PureScript. Once that gets resolved, we should update the readme to include the 'try' link again (./scrips/generateRecipeTable.sh)
@JordanMartinez JordanMartinez added the cookbook Issues related to this repo as a whole and not a recipe in particular label Jul 16, 2022
@pete-murphy
Copy link
Collaborator

pete-murphy commented Jul 16, 2022 •
edited
Loading

Might already be obvious, but just noting: if #294 is merged, I think we'll also need to shim React 18 in Try PureScript (currently on 16.x) before enabling the try links for React recipes. Edit: actually will probably want to update the shim regardless of the cookbook links, since react-basic-dom now uses React 18 API.

@JordanMartinez
Copy link
Owner Author

That's correct. It also means we should update the purescript-react/purescript-react-dom libraries to use React 18 and verify they still work. The package.json files are on React 16.

@JordanMartinez JordanMartinez mentioned this issue Jul 23, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
cookbook Issues related to this repo as a whole and not a recipe in particular
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add try links now that TPS is fixed JordanMartinez/purescript-cookbook
2 participants
@JordanMartinez @pete-murphy