Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

React v18 update #294

Merged
merged 4 commits into from
Jul 26, 2022
Merged

Conversation

andys8
Copy link
Contributor

@andys8 andys8 commented Jul 16, 2022

This is the suggested update path to react v18:

If this change is good to go, I can roll it out to all ReactHooks examples.

./BookReactHooks/
./ButtonsReactHooks/
./CardsReactHooks/
./CatGifsReactHooks/
./ClockReactHooks/
./ComponentsInputReactHooks/
./ComponentsMultiTypeReactHooks/
./ComponentsReactHooks/
./DragAndDropReactHooks/
./FileUploadReactHooks/
./FormsReactHooks/
./GroceriesReactHooks/
./HelloReactHooks/
./ImagePreviewsReactHooks/
./NumbersReactHooks/
./PositionsReactHooks/
./RoutingHashReactHooks/
./RoutingPushReactHooks/
./ShapesReactHooks/
./TextFieldsReactHooks/
./TicTacToeReactHooks/
./TimeReactHooks/

@JordanMartinez
Copy link
Owner

This looks good, but the only issue is the override in the packages.dhall file. (See https://github.com/JordanMartinez/purescript-cookbook/blob/master/CONTRIBUTING.md#only-use-packages-in-the-latest-package-set-release)

I get that the changes needed are in master for that library, but I'd still prefer to wait until an official release is made.

Other than that, yeah, this seems fine to me.

@andys8 andys8 marked this pull request as draft July 16, 2022 16:11
@andys8
Copy link
Contributor Author

andys8 commented Jul 16, 2022

Yes, the override will be dropped and replaced by package set update before merge. Converted to draft PR to make clear this won't be merged in its current state.

@JordanMartinez
Copy link
Owner

Yes, the override will be dropped and replaced by package set update before merge. Converted to draft PR to make clear this won't be merged in its current state.

Sounds good!

@JordanMartinez
Copy link
Owner

Looks like we only need to update the react dependency in Try PureScript, update the package set here to remove the override and use the latest release, and then this is good to merge. Is that right?

@andys8
Copy link
Contributor Author

andys8 commented Jul 23, 2022

Aaaaand... update all the other react examples. Currently only one of them is modified. This can be another pullrequest though, since the api is deprecated, but not broken and will still work.

The latest package set doesn't have the react update. With the next package set, we'll have it.

@andys8 andys8 marked this pull request as ready for review July 25, 2022 11:39
@andys8
Copy link
Contributor Author

andys8 commented Jul 25, 2022

Updated the package set. I would be fine with merging this PR as is:

  • Only updating "HelloReactHooks".
  • Next PR: Format repository with purs-tidy
  • Next PR: Update all other react examples.

The current and expected state of the non-updated react examples is to see these warnings. They're exactly what this PR solved, but only for "HelloReactHooks". The examples with warnings still work.

image

image

@JordanMartinez
Copy link
Owner

Thanks!

@JordanMartinez JordanMartinez merged commit 3bbeca8 into JordanMartinez:master Jul 26, 2022
@andys8 andys8 mentioned this pull request Aug 10, 2022
22 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants