Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add text fields halogen #105

Merged
merged 9 commits into from
Jul 1, 2020
Merged

Add text fields halogen #105

merged 9 commits into from
Jul 1, 2020

Conversation

JordanMartinez
Copy link
Owner

@JordanMartinez JordanMartinez commented Jun 30, 2020

Addresses part of #86.

[ HH.input
[ HP.placeholder "Text to reverse"
, HP.value state
, HE.onInput \newValue -> Just $ Hooks.put stateIdx (?reverseString newValue)
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Somehow, CI built find despite this line. ?reverseString should have created a compiler error, making the build fail. However, I don't see any such errors in the build for this recipe. That's a problem...

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This issue was actually caused by the web/index.js file referring to the original recipe I duplicated when I originally started working on this recipe

@JordanMartinez JordanMartinez merged commit f20b3f3 into master Jul 1, 2020
@JordanMartinez JordanMartinez deleted the addTextFieldsHalogen branch July 1, 2020 03:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant