Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify ComponentsHalogenHooks #252

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

milesfrain
Copy link
Collaborator

I was initially confused about how ButtonMessage was being used, and then realized that the component's output value is simply ignored by the parent when incrementing toggle count. So this can be replaced with Unit. Don't know whether this makes things more or less confusing. We could alternatively go with an Output alias and some more comments.

@JordanMartinez
Copy link
Owner

Nah, that's fine. Using unit is better.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants