RoutingHashReactHooks does not work in TryPureScript #273
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I want to say this is an issue with Try PureScript, but I'm not really sure what is causing it. Either way, I think we should merge this to prevent this unexpected behavior. |
|
try.ps.ai generates the iframe a bit differently than the original site, and this is definitely a regression. Thanks for reporting. I'll dig into this whenever I get around to making another pass at merging with upstream. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This recipe causes odd behavior in TryPureScript (as first noted here: #271 (comment), and pictured below) where clicking on a link will re-direct such that the
<iframe>renders a nested instance of TryPureScript. I've added atryUnsupported.mdand removed the Try link from theREADMEtable of contents. Interestingly this exact code will work if run as a gist in TryPureScript. This seems to be unexpected behavior; should I open an actual issue to track this?