Remove unnecessary Unsafe.Coerce usage #276
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hmm getting a couple of errors in CI: and |
|
Seems to be an issue with Edit: I went with a patch-version upgrade to v1.12.5, since it seems v2 is still in beta. |
pete-murphy
force-pushed
the
@ptrfrncsmrph/fix-to-drag-event-impl
branch
from
1c39c7b
to
5f91cdb
Compare
pete-murphy
force-pushed
the
@ptrfrncsmrph/fix-to-drag-event-impl
branch
from
5f91cdb
to
1a769ca
Compare
milesfrain
approved these changes
Apr 25, 2021
JordanMartinez
approved these changes
Apr 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Slight refactor to get rid of the homespun
toDragEventhere and remove the usage ofUnsafe.Coerce.coerce. I wasn't aware ofReact.Basic.DOM.Events.nativeEventat the time.