Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: giphy cat api has updated, updating CatGifsReactHook to match #288

Merged
merged 2 commits into from
Feb 14, 2022

Conversation

neilhan
Copy link
Contributor

@neilhan neilhan commented Feb 14, 2022

CatGifsReactHook was trying to extract a gif url that does not match the latest giphy respones.
Updated the getRandomCatGif function to work with latest giphy API

Copy link
Collaborator

@pete-murphy pete-murphy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍 thanks!

Looks like a similar fix is needed for the counterpart Halogen recipe, I'll open an issue for that.

@neilhan neilhan changed the title chore: giphy cat api has updated, updating to match chore: giphy cat api has updated, updating CatGifsReactHook to match Feb 14, 2022
@JordanMartinez
Copy link
Owner

Thanks!

@pete-murphy
Copy link
Collaborator

Tested this locally and works as expected. I opened a separate issue for the Halogen recipe: #289

@pete-murphy pete-murphy merged commit 9e35409 into JordanMartinez:master Feb 14, 2022
@neilhan neilhan deleted the catgifsreacthooks branch February 16, 2022 05:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants