Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Bump Node version to latest LTS #305

Merged
merged 1 commit into from
Aug 11, 2023
Merged

Conversation

pete-murphy
Copy link
Collaborator

Seeing the following error in the CI build for #304

=== Building HelloLog for the web browser backend ===
/home/runner/work/purescript-cookbook/purescript-cookbook/node_modules/@parcel/utils/lib/index.js:37573
    #getIndex(item) {
             ^

SyntaxError: Unexpected token '('

#getIndex is using relatively new private class field syntax. According to MDN, that should be valid in Node v12 so I'm not sure why this is failing with a syntax error. Trying to bump to v18 to see if that helps.

@pete-murphy
Copy link
Collaborator Author

I'll go ahead and merge this, just a version bump that appears to fix CI following a breaking change in parcel

@pete-murphy pete-murphy merged commit 7992e8e into master Aug 11, 2023
1 check passed
@pete-murphy pete-murphy removed the request for review from JordanMartinez August 11, 2023 01:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant