Update to beyond alpha.7 #244
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…abbing authorities fro mthe runtime.
Co-authored-by: David <dvdplm@gmail.com>
Closed
pallets/offchain-demo/src/lib.rs
Outdated
Comment on lines
58
to
85
| use sp_runtime::{ | ||
| app_crypto::{app_crypto, sr25519}, | ||
| MultiSigner, MultiSignature, | ||
| traits::Verify, | ||
| }; | ||
| use sp_core::sr25519::Signature as Sr25519Signature; | ||
|
|
||
| app_crypto!(sr25519, KEY_TYPE); | ||
|
|
||
| pub struct TestAuthId; | ||
| // implemented for ocw-runtime | ||
| impl frame_system::offchain::AppCrypto<MultiSigner, MultiSignature> for TestAuthId | ||
| { | ||
| type RuntimeAppPublic = Public; | ||
| type GenericSignature = sp_core::sr25519::Signature; | ||
| type GenericPublic = sp_core::sr25519::Public; | ||
| } | ||
|
|
||
| // implemented for mock runtime in test | ||
| impl frame_system::offchain::AppCrypto<<Sr25519Signature as Verify>::Signer, Sr25519Signature> for TestAuthId | ||
| { | ||
| type RuntimeAppPublic = Public; | ||
| type GenericSignature = sp_core::sr25519::Signature; | ||
| type GenericPublic = sp_core::sr25519::Public; | ||
| } | ||
| } | ||
|
|
||
| // Specifying serde path as `alt_serde` |
There was a problem hiding this comment.
There is maybe some ticket system like JIRA or just you are using Issues from Github? I ask because I am curious where/how I find the description of the PR.
There was a problem hiding this comment.
The description is at the top of this page. This particular PR is a weird one though. It contains a lot of changes from the base branch because this repo (the recipes) is in the process of adopting gitflow to manage PRs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This WIP PR updates the recipes to beyond alpha.7. It replaces #242
In Substrate's alpha.7 release, the instant- and manual-seal consensus engines are completely broken. That issue is fixed in Substrate in paritytech/substrate#5955 . Because the recipes critically depends on instant- and manual-seal, the recipes will skip the alpha.7 release. That means that this PR also reverts crates.io dependencies to git dependencies :shudder:.
TODO: