-
-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: duplicated comments #588
Changes from 1 commit
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change | ||||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
|
@@ -15,6 +15,14 @@ export function traverseAndModifyAst(ast: Node) { | |||||||||||||||||
modifyNodeIfMissingBrackets(node) && | ||||||||||||||||||
nodeNotAlreadySeen(node, seenNodes) | ||||||||||||||||||
) { | ||||||||||||||||||
// Remove comments from the original node to avoid duplication | ||||||||||||||||||
if (node.leadingComments) { | ||||||||||||||||||
delete node.leadingComments; | ||||||||||||||||||
} | ||||||||||||||||||
if (node.trailingComments) { | ||||||||||||||||||
delete node.trailingComments; | ||||||||||||||||||
} | ||||||||||||||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. [Question] Any reason for the
Suggested change
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Good catch :D I forgot delete doesn't throw if the property doesn't exist on the object, so the if statements are unnecessary. I've removed them |
||||||||||||||||||
|
||||||||||||||||||
modifiedNodes.add(node); | ||||||||||||||||||
} | ||||||||||||||||||
} | ||||||||||||||||||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 yeah agreement from me, I can't find any issues. If anything pops up in the future then great, it should be represented here as a test case.