fix: check key values, not get return for haskey(k, orderedrobindict)

src/ordered_robin_dict.jl

@@ -305,10 +305,10 @@ julia> haskey(D, 'c')
 false
 ```
 """
-Base.haskey(h::OrderedRobinDict, key) = (get(h.dict, key, -2) > 0)
-Base.in(key, v::Base.KeySet{K,T}) where {K,T<:OrderedRobinDict{K}} = (get(v.dict, key, -1) >= 0)
+Base.haskey(h::OrderedRobinDict, key) = key in h.keys
+Base.in(key, v::Base.KeySet{K,T}) where {K,T<:OrderedRobinDict{K}} = key in v.dict.keys
 
-"""
+"""(get(h.dict, key, -2) > 0)
     getkey(collection, key, default)
 
 Return the key matching argument `key` if one exists in `collection`, otherwise return `default`.

test/test_ordered_robin_dict.jl

@@ -31,22 +31,22 @@
 
         # access, modification
         for c in 'a':'z'
-            d[c] = c - 'a' + 1
+            d[c] = c - 'a' - 2
         end
 
-        @test (d['a'] += 1) == 2
+        @test (d['a'] += 1) == -1
         @test 'a' in keys(d)
         @test haskey(d, 'a')
         @test get(d, 'B', 0) == 0
         @test getkey(d, 'b', nothing) == 'b'
         @test getkey(d, 'B', nothing) == nothing
         @test !('B' in keys(d))
         @test !haskey(d, 'B')
-        @test pop!(d, 'a') == 2
+        @test pop!(d, 'a') == -1
 
         @test collect(keys(d)) == collect('b':'z')
-        @test collect(values(d)) == collect(2:26)
-        @test collect(d) == [Pair(a,i) for (a,i) in zip('b':'z', 2:26)]
+        @test collect(values(d)) == collect(-1:23)
+        @test collect(d) == [Pair(a,i) for (a,i) in zip('b':'z', -1:23)]
     end
 
     @testset "convert" begin