fix: check key values, not get return for haskey(k, orderedrobindict)
#858
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I discovered the same problem in |
|
Okay, I didn't understand the code as well as I should have on my first pass. I fixed setindex! to use I also |
oscardssmith
approved these changes
Jun 12, 2023
eulerkochy
approved these changes
Jun 20, 2023
test/test_ordered_robin_dict.jl
Outdated
| @@ -139,6 +139,8 @@ | |||
| @test h["a","b"] == h[("a","b")] == 4 | |||
| h["a","b","c"] = 4 | |||
| @test h["a","b","c"] == h[("a","b","c")] == 4 | |||
| h["b"] = missing | |||
| @test 5 == (h["b"] = 5) | |||
| end | |||
|
|
|||
There was a problem hiding this comment.
Can you add a testset (you can name the testset "Fixes issue 857") corresponding to fixed scenarios that you mentioned here
There was a problem hiding this comment.
I rolled back all the changes to the tests and consolidated all the changes under a single testset!
oxinabox
pushed a commit
that referenced
this pull request
Jun 29, 2023
…t) (#858) * fix: check key values, not `get` return for haskey(k, orderedrobindict) * Fix: use isequal in setindex! * re-fix: use `get` for `in keys()` but descend to the actual id-dict * Remove accidental paste in docstring * consolidate tests for issue under testset --------- Co-authored-by: Micah Rufsvold <mjrufsvold@mathematica-mpr.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #857
I am not sure if checking if the key appears in the key vector property is the right way to go. Open to another solution!