Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for MutableLinkedList append! #871

Merged
merged 3 commits into from
Oct 23, 2023
Merged

Fix for MutableLinkedList append! #871

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0149cc4
Correctly set previous and next nodes when appending
Sinfaen Sep 1, 2023
610f34d
Add test for checking that append! takes elements from second arg
Sinfaen Sep 1, 2023
940e11f
Merge branch 'JuliaCollections:master' into ll-fix-append
Sinfaen Oct 22, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions src/mutable_list.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -153,7 +153,13 @@ end
function Base.append!(l1::MutableLinkedList{T}, l2::MutableLinkedList{T}) where T
l1.node.prev.next = l2.node.next # l1's last's next is now l2's first
l2.node.prev.next = l1.node # l2's last's next is now l1.node
l2.node.next.prev = l1.node.prev # l2's first's prev is now l1's last
l1.node.prev = l2.node.prev # l1's first's prev is now l2's last
l1.len += length(l2)
# make l2 empty
l2.node.prev = l2.node
l2.node.next = l2.node
l2.len = 0
return l1
end

Expand Down
3 changes: 2 additions & 1 deletion test/test_mutable_list.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,7 +97,8 @@
@testset "append" begin
l2 = MutableLinkedList{Int}(n+1:2n...)
append!(l, l2)
@test l == MutableLinkedList{Int}(1:2n...)
@test l == MutableLinkedList{Int}(1:2n...)
@test l2 == MutableLinkedList{Int}()
@test collect(l) == collect(MutableLinkedList{Int}(1:2n...))
l3 = MutableLinkedList{Int}(1:n...)
append!(l3, n+1:2n...)
Expand Down
Loading