Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make balance_statespace work for more system types #837

Merged
merged 3 commits into from
May 13, 2023
Merged

Conversation

baggepinnen
Copy link
Member

closes #835

@JuliaControlBot
Copy link

This is an automated message.
Plots were compared to references. 11/11 images have changed, see differences below.
After pulling this PR, please update the reference images by creating a PR to ControlExamplePlots.jl here.

Difference Reference Image New Image
❌ 0.047 Reference New
✔️ 0.011 Reference New
✔️ 0.001 Reference New
✔️ 0.001 Reference New
✔️ 0.007 Reference New
✔️ 0.003 Reference New
✔️ 0.0 Reference New
⚠️ 0.028 Reference New
❌ 0.06 Reference New
✔️ 0.0 Reference New
⚠️ 0.017 Reference New

@codecov
Copy link

codecov bot commented May 12, 2023

Codecov Report

Merging #837 (3c7632f) into master (ba2713d) will increase coverage by 1.58%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #837      +/-   ##
==========================================
+ Coverage   95.55%   97.14%   +1.58%     
==========================================
  Files           4        4              
  Lines         315      315              
==========================================
+ Hits          301      306       +5     
+ Misses         14        9       -5     

see 1 file with indirect coverage changes

@baggepinnen baggepinnen merged commit 3c68895 into master May 13, 2023
5 checks passed
@baggepinnen baggepinnen deleted the generibal branch May 13, 2023 08:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

minreal works -- but gives "wrong" result
2 participants