Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

optimize performance of sigma #840

Merged
merged 1 commit into from
May 17, 2023
Merged

optimize performance of sigma #840

merged 1 commit into from
May 17, 2023

Conversation

baggepinnen
Copy link
Member

For MISO and SIMO systems, it is significantly faster to call norm rather than svdvals

@codecov
Copy link

codecov bot commented May 17, 2023

Codecov Report

Merging #840 (0bae63a) into master (f62c25c) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #840   +/-   ##
=======================================
  Coverage   97.14%   97.14%           
=======================================
  Files           4        4           
  Lines         315      315           
=======================================
  Hits          306      306           
  Misses          9        9           

@JuliaControlBot
Copy link

This is an automated message.
Plots were compared to references. 11/11 images have changed, see differences below.
After pulling this PR, please update the reference images by creating a PR to ControlExamplePlots.jl here.

Difference Reference Image New Image
❌ 0.047 Reference New
✔️ 0.011 Reference New
✔️ 0.001 Reference New
✔️ 0.001 Reference New
✔️ 0.007 Reference New
✔️ 0.003 Reference New
✔️ 0.0 Reference New
⚠️ 0.028 Reference New
❌ 0.06 Reference New
✔️ 0.0 Reference New
⚠️ 0.017 Reference New

@baggepinnen baggepinnen merged commit 688d26d into master May 17, 2023
6 checks passed
@baggepinnen baggepinnen deleted the sigmaopt branch May 17, 2023 11:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants