Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make schur factorization differentiable #849

Merged
merged 1 commit into from
May 30, 2023
Merged

make schur factorization differentiable #849

merged 1 commit into from
May 30, 2023

Conversation

baggepinnen
Copy link
Member

@baggepinnen baggepinnen commented May 25, 2023

@codecov
Copy link

codecov bot commented May 25, 2023

Codecov Report

Merging #849 (39a90d4) into master (42e3955) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #849   +/-   ##
=======================================
  Coverage   92.72%   92.72%           
=======================================
  Files           5        5           
  Lines         330      330           
=======================================
  Hits          306      306           
  Misses         24       24           

@JuliaControlBot
Copy link

This is an automated message.
Plots were compared to references. 11/11 images have changed, see differences below.
After pulling this PR, please update the reference images by creating a PR to ControlExamplePlots.jl here.

Difference Reference Image New Image
❌ 0.047 Reference New
✔️ 0.011 Reference New
✔️ 0.001 Reference New
✔️ 0.001 Reference New
✔️ 0.007 Reference New
✔️ 0.003 Reference New
✔️ 0.0 Reference New
⚠️ 0.028 Reference New
❌ 0.06 Reference New
✔️ 0.0 Reference New
⚠️ 0.017 Reference New

@JuliaControlBot
Copy link

This is an automated message.
Plots were compared to references. 11/11 images have changed, see differences below.
After pulling this PR, please update the reference images by creating a PR to ControlExamplePlots.jl here.

Difference Reference Image New Image
❌ 0.047 Reference New
✔️ 0.011 Reference New
✔️ 0.001 Reference New
✔️ 0.001 Reference New
✔️ 0.007 Reference New
✔️ 0.003 Reference New
✔️ 0.0 Reference New
⚠️ 0.028 Reference New
❌ 0.06 Reference New
✔️ 0.0 Reference New
⚠️ 0.017 Reference New

@gdalle
Copy link

gdalle commented May 27, 2023

Can you merge this without that release of ImplicitDifferentiation? I'm not yet sure how to make it work in reverse mode

@baggepinnen baggepinnen merged commit 87d6013 into master May 30, 2023
5 checks passed
@baggepinnen baggepinnen deleted the diffschur branch May 30, 2023 17:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants