Incorporate changes from #344 #881
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
baggepinnen
reviewed
Oct 10, 2023
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #881 +/- ##
=======================================
Coverage 92.72% 92.72%
=======================================
Files 5 5
Lines 330 330
=======================================
Hits 306 306
Misses 24 24 ☔ View full report in Codecov by Sentry. |
I changed them for a reason, but fair enough. Done ^_^ |
albheim
reviewed
Oct 11, 2023
| @@ -0,0 +1,3 @@ | |||
| { | |||
| "workbench.colorTheme": "Julia (Monokai Vibrant)" | |||
There was a problem hiding this comment.
Was this really supposed to be added?
There was a problem hiding this comment.
I am sorry, no. VSCode keeps adding this file in every folder I open with VSCode, which has made its way into more than one git commit. I will make a PR to remove it.
There was a problem hiding this comment.
Deleted the folder in #882
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I finally made a branch in the correct way, and incorporated the changed made in #344. I left out the changes for the linestyles, as I honestly do not know their effect anymore, and the code-base has changed significantly.
Porting 344 was done by copy-pasting and incoperating to the best of my ability. The original changes were however made long ago, so this PR definitively needs some external checking.