Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upper-bound length of default time vector #887

Merged
merged 1 commit into from
Oct 12, 2023
Merged

Conversation

baggepinnen
Copy link
Member

closes #880

@JuliaControlBot
Copy link

This is an automated message.
Plots were compared to references. 11/11 images have changed, see differences below.
After pulling this PR, please update the reference images by creating a PR to ControlExamplePlots.jl here.

Difference Reference Image New Image
❌ 0.047 Reference New
✔️ 0.011 Reference New
✔️ 0.001 Reference New
✔️ 0.001 Reference New
✔️ 0.007 Reference New
✔️ 0.003 Reference New
✔️ 0.0 Reference New
⚠️ 0.028 Reference New
❌ 0.06 Reference New
✔️ 0.0 Reference New
⚠️ 0.017 Reference New

@codecov
Copy link

codecov bot commented Oct 12, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (16aa4bc) 92.72% compared to head (ce31629) 56.53%.

Additional details and impacted files
@@             Coverage Diff             @@
##           master     #887       +/-   ##
===========================================
- Coverage   92.72%   56.53%   -36.20%     
===========================================
  Files           5        5               
  Lines         330      329        -1     
===========================================
- Hits          306      186      -120     
- Misses         24      143      +119     

see 3 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@baggepinnen baggepinnen merged commit 71091fc into master Oct 12, 2023
5 of 6 checks passed
@baggepinnen baggepinnen deleted the defaulttime branch October 12, 2023 11:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

OutOfMemoryError on step without time step size
2 participants