Small changes in API #34
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahojukka5
force-pushed
the
release-0.2.1
branch
from
48ad70b
to
266e60a
Compare
* New function get_problem(problem, name) to fetch a problem from a analysis. * Update docstrings. * Connectivity can be given with tuple when creating new element. * Be more information (@info) when calling functions to be more responsible. * Preparations to separate topology and basis. * Remove function to update properties with string pairs, it's quite unpractical approach (we still should implement something like update_properties!(...) ). * `add_elements!`, `add_problems!`, takes also varargs, so can also call `add_elements!(p, e1, e2)` instead of creating first iterable. * `update!` can take list of elements as tuple. * `SparseMatrixCOO` and `SparseVectorCOO` can be converted to full matrices / vectors using `Matrix` and `Vector`. * Comparison of `SparseMatrixCOO` with matrix / vector using `isapprox`. * `add!` returns nothing.
ahojukka5
force-pushed
the
release-0.2.1
branch
from
266e60a
to
5d5fdb0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add_elements!,add_problems!, takes also varargs, so can also calladd_elements!(p, e1, e2)instead of creating first iterable.update!can take list of elements as tuple.SparseMatrixCOOandSparseVectorCOOcan be converted to full matrices / vectors usingMatrixandVector.SparseMatrixCOOwith matrix / vector usingisapprox.add!returns nothing.