Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Short channel matching for julia command #836

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

rakeshksr
Copy link

Closes #830
This pull request introduces the feature of short channel matching for the Julia command. Users can now launch alpha, beta, LTS, release, and nightly versions by specifying their respective short names: "a" for alpha, "b" for beta, "l" for LTS, "r" for release, and "n" for nightly.

@LilithHafner
Copy link
Member

LilithHafner commented Jul 3, 2024

This error message is interesting, but upon reflection seems pretty good. It would be slightly better if the message explicitly mentioned that l expanded to lts.

$ julia +l
`lts` is not installed. Please run `juliaup add lts` to install channel or version.

Copy link
Member

@LilithHafner LilithHafner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This only supports single character abbreviations, not intermediary abbreviations. I think that's okay.

LGTM

@LilithHafner
Copy link
Member

Would be good to add a test, too

@LilithHafner
Copy link
Member

Needs docs

@davidanthoff
Copy link
Collaborator

I think I've finally am getting clarity what I'm thinking about this, see #830.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support short channel matching
3 participants