Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add functionality for importing conda environments (From yaml files) #39

Closed
wants to merge 7 commits into from
Closed

Conversation

tylerjthomas9
Copy link
Contributor

@tylerjthomas9 tylerjthomas9 commented Jul 5, 2022

I am curious what you think of the additions. I have personally needed this functionality for importing an environment from an conda generated yaml file.

@codecov
Copy link

codecov bot commented Jul 5, 2022

Codecov Report

Merging #39 (0602e94) into main (d1aaa70) will increase coverage by 0.08%.
The diff coverage is 95.83%.

@@            Coverage Diff             @@
##             main      #39      +/-   ##
==========================================
+ Coverage   93.11%   93.19%   +0.08%     
==========================================
  Files           7        8       +1     
  Lines         755      779      +24     
==========================================
+ Hits          703      726      +23     
- Misses         52       53       +1     
Impacted Files Coverage Δ
src/import.jl 95.83% <95.83%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d1aaa70...0602e94. Read the comment docs.

@cjdoris
Copy link
Collaborator

cjdoris commented Jul 20, 2022

Hi, sorry for the slow response. Thanks for the PR. It's a neat idea but I'm reluctant to add anything that's not core functionality to this package, partly because it's more to maintain and partly because the extra dependency adds to the startup time for people who don't use that functionality.

A couple of options could be to make it a separate small package (I'd be happy to link to it from various docs) or add it as a contributed script to this package.

@tylerjthomas9
Copy link
Contributor Author

That makes sense! Thank you for taking a look at it. I'll probably move it to an example script.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants