Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

simplifications #82

Merged
merged 1 commit into from
May 14, 2023
Merged

simplifications #82

merged 1 commit into from
May 14, 2023

Conversation

t-bltg
Copy link
Contributor

@t-bltg t-bltg commented Mar 28, 2023

A few resolve simplifications:

  1. do not parse an already parsed file (spurious Found dependencies: messages)
  2. don't add an already added path in extra_path (less i/o ops with stat).

@codecov
Copy link

codecov bot commented Mar 28, 2023

Codecov Report

Merging #82 (dab8798) into main (5dbe1b6) will increase coverage by 0.02%.
The diff coverage is 66.66%.

@@            Coverage Diff             @@
##             main      #82      +/-   ##
==========================================
+ Coverage   92.78%   92.80%   +0.02%     
==========================================
  Files           7        7              
  Lines         859      862       +3     
==========================================
+ Hits          797      800       +3     
  Misses         62       62              
Impacted Files Coverage Δ
src/resolve.jl 93.85% <66.66%> (+0.04%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@cjdoris
Copy link
Collaborator

cjdoris commented Mar 29, 2023

Looks good, thank you.

I'm curious, in what situation are you getting those repeats?

@t-bltg
Copy link
Contributor Author

t-bltg commented Mar 29, 2023

I was investigating an irritating thing (bug ?), where creating a directory in a local project folder would fail _resolve_can_skip_1 and thus making the cached STATE unresolved.

EDIT: split into dedicated issue: #83.

This PR doesn't fix #83, but still worth it I guess.

@cjdoris cjdoris merged commit 4d48894 into JuliaPy:main May 14, 2023
@t-bltg t-bltg deleted the speedup branch May 14, 2023 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants