Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
go/internal/gcimporter: call Interface.Complete in unified importer
To support concurrent use of the go/types API, importers need to call Interface.Complete on constructed interfaces before returning. There's an issue that the interfaces may contain embedded defined types, whose underlying type isn't known yet. This issue will eventually go away once CL 424876 lands, but that CL needs to wait for CL 424854 to re-land, which needs to wait for CL 421879 to land... In the mean time, this CL implements the same solution used by the indexed importer: maintaining a list of constructed interfaces, and calling Interface.Complete on them after the SetUnderlying loop and just before returning the imported package. Updates golang#54653. Change-Id: I0f42c915a4b7d28c628bbab7ac2eab2415c7858f Reviewed-on: https://go-review.googlesource.com/c/go/+/425360 TryBot-Result: Gopher Robot <gobot@golang.org> Run-TryBot: Matthew Dempsky <mdempsky@google.com> Reviewed-by: Robert Griesemer <gri@google.com>
- Loading branch information