Skip to content

Commit

Permalink
Remove solaris build tag and `contrib/mkimage/solaris
Browse files Browse the repository at this point in the history
Signed-off-by: Yong Tang <yong.tang.github@outlook.com>
  • Loading branch information
yongtang committed Nov 2, 2017
1 parent deae428 commit 4785f1a
Show file tree
Hide file tree
Showing 61 changed files with 51 additions and 172 deletions.
2 changes: 1 addition & 1 deletion client/client_unix.go
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
// +build linux freebsd solaris openbsd darwin
// +build linux freebsd openbsd darwin

package client

Expand Down
2 changes: 1 addition & 1 deletion cmd/dockerd/config_common_unix.go
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
// +build solaris linux freebsd
// +build linux freebsd

package main

Expand Down
2 changes: 1 addition & 1 deletion cmd/dockerd/config_unix.go
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
// +build linux,!solaris freebsd,!solaris
// +build linux freebsd

package main

Expand Down
2 changes: 1 addition & 1 deletion cmd/dockerd/config_unix_test.go
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
// +build linux,!solaris freebsd,!solaris
// +build linux freebsd

package main

Expand Down
2 changes: 1 addition & 1 deletion cmd/dockerd/daemon_unix.go
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
// +build !windows,!solaris
// +build !windows

package main

Expand Down
5 changes: 1 addition & 4 deletions cmd/dockerd/daemon_unix_test.go
Original file line number Diff line number Diff line change
@@ -1,7 +1,4 @@
// +build !windows,!solaris

// TODO: Create new file for Solaris which tests config parameters
// as described in daemon/config_solaris.go
// +build !windows

package main

Expand Down
4 changes: 2 additions & 2 deletions container/container_notlinux.go
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
// +build solaris freebsd
// +build freebsd

package container

Expand All @@ -7,7 +7,7 @@ import (
)

func detachMounted(path string) error {
//Solaris and FreeBSD do not support the lazy unmount or MNT_DETACH feature.
// FreeBSD do not support the lazy unmount or MNT_DETACH feature.
// Therefore there are separate definitions for this.
return unix.Unmount(path, 0)
}
Expand Down
2 changes: 1 addition & 1 deletion container/container_unix.go
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
// +build linux freebsd solaris
// +build linux freebsd

package container

Expand Down
2 changes: 1 addition & 1 deletion contrib/docker-device-tool/device_tool.go
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
// +build !windows,!solaris
// +build !windows

package main

Expand Down
8 changes: 0 additions & 8 deletions contrib/mkimage.sh
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,6 @@ usage() {
echo >&2 " $mkimg -t someuser/centos:5 rinse --distribution centos-5"
echo >&2 " $mkimg -t someuser/mageia:4 mageia-urpmi --version=4"
echo >&2 " $mkimg -t someuser/mageia:4 mageia-urpmi --version=4 --mirror=http://somemirror/"
echo >&2 " $mkimg -t someuser/solaris solaris"
exit 1
}

Expand All @@ -20,13 +19,6 @@ scriptDir="$(dirname "$(readlink -f "$BASH_SOURCE")")/mkimage"
os=
os=$(uname -o)

# set up path to gnu tools if solaris
[[ $os == "Solaris" ]] && export PATH=/usr/gnu/bin:$PATH
# TODO check for gnu-tar, gnu-getopt

# TODO requires root/sudo due to some pkg operations. sigh.
[[ $os == "Solaris" && $EUID != "0" ]] && echo >&2 "image create on Solaris requires superuser privilege"

optTemp=$(getopt --options '+d:t:c:hC' --longoptions 'dir:,tag:,compression:,no-compression,help' --name "$mkimg" -- "$@")
eval set -- "$optTemp"
unset optTemp
Expand Down
89 changes: 0 additions & 89 deletions contrib/mkimage/solaris

This file was deleted.

2 changes: 1 addition & 1 deletion daemon/cluster/listen_addr_others.go
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
// +build !linux,!solaris
// +build !linux

package cluster

Expand Down
2 changes: 1 addition & 1 deletion daemon/config/config_common_unix.go
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
// +build solaris linux freebsd
// +build linux freebsd

package config

Expand Down
2 changes: 0 additions & 2 deletions daemon/daemon_test.go
Original file line number Diff line number Diff line change
@@ -1,5 +1,3 @@
// +build !solaris

package daemon

import (
Expand Down
2 changes: 1 addition & 1 deletion daemon/daemon_unix_test.go
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
// +build !windows,!solaris
// +build !windows

package daemon

Expand Down
2 changes: 1 addition & 1 deletion daemon/daemon_unsupported.go
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
// +build !linux,!freebsd,!windows,!solaris
// +build !linux,!freebsd,!windows

package daemon

Expand Down
2 changes: 1 addition & 1 deletion daemon/debugtrap_unsupported.go
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
// +build !linux,!darwin,!freebsd,!windows,!solaris
// +build !linux,!darwin,!freebsd,!windows

package daemon

Expand Down
2 changes: 1 addition & 1 deletion daemon/getsize_unix.go
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
// +build linux freebsd solaris
// +build linux freebsd

package daemon

Expand Down
2 changes: 1 addition & 1 deletion daemon/graphdriver/driver_unsupported.go
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
// +build !linux,!windows,!freebsd,!solaris
// +build !linux,!windows,!freebsd

package graphdriver

Expand Down
2 changes: 1 addition & 1 deletion daemon/graphdriver/graphtest/graphtest_unix.go
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
// +build linux freebsd solaris
// +build linux freebsd

package graphtest

Expand Down
2 changes: 1 addition & 1 deletion daemon/graphdriver/register/register_zfs.go
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
// +build !exclude_graphdriver_zfs,linux !exclude_graphdriver_zfs,freebsd, solaris
// +build !exclude_graphdriver_zfs,linux !exclude_graphdriver_zfs,freebsd

package register

Expand Down
2 changes: 1 addition & 1 deletion daemon/graphdriver/zfs/zfs.go
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
// +build linux freebsd solaris
// +build linux freebsd

package zfs

Expand Down
2 changes: 1 addition & 1 deletion daemon/graphdriver/zfs/zfs_unsupported.go
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
// +build !linux,!freebsd,!solaris
// +build !linux,!freebsd

package zfs

Expand Down
2 changes: 1 addition & 1 deletion daemon/inspect_unix.go
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
// +build !windows,!solaris
// +build !windows

package daemon

Expand Down
2 changes: 1 addition & 1 deletion daemon/list_unix.go
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
// +build linux freebsd solaris
// +build linux freebsd

package daemon

Expand Down
2 changes: 1 addition & 1 deletion daemon/listeners/listeners_unix.go
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
// +build !windows,!solaris
// +build !windows

package listeners

Expand Down
2 changes: 1 addition & 1 deletion daemon/logger/plugin_unix.go
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
// +build linux solaris freebsd
// +build linux freebsd

package logger

Expand Down
2 changes: 1 addition & 1 deletion daemon/logger/plugin_unsupported.go
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
// +build !linux,!solaris,!freebsd
// +build !linux,!freebsd

package logger

Expand Down
2 changes: 0 additions & 2 deletions daemon/reload_test.go
Original file line number Diff line number Diff line change
@@ -1,5 +1,3 @@
// +build !solaris

package daemon

import (
Expand Down
2 changes: 0 additions & 2 deletions daemon/stats/collector.go
Original file line number Diff line number Diff line change
@@ -1,5 +1,3 @@
// +build !solaris

package stats

import (
Expand Down
2 changes: 1 addition & 1 deletion daemon/stats/collector_unix.go
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
// +build !windows,!solaris
// +build !windows

package stats

Expand Down
2 changes: 0 additions & 2 deletions daemon/volumes_unix.go
Original file line number Diff line number Diff line change
@@ -1,7 +1,5 @@
// +build !windows

// TODO(amitkris): We need to split this file for solaris.

package daemon

import (
Expand Down
2 changes: 1 addition & 1 deletion layer/layer_unix.go
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
// +build linux freebsd darwin openbsd solaris
// +build linux freebsd darwin openbsd

package layer

Expand Down
Original file line number Diff line number Diff line change
@@ -1,5 +1,3 @@
// +build linux solaris

package libcontainerd

import (
Expand Down
Original file line number Diff line number Diff line change
@@ -1,5 +1,3 @@
// +build linux solaris

package libcontainerd

import "fmt"
Expand Down
Original file line number Diff line number Diff line change
@@ -1,5 +1,3 @@
// +build linux solaris

package libcontainerd

import (
Expand Down
2 changes: 1 addition & 1 deletion pkg/directory/directory_unix.go
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
// +build linux freebsd solaris
// +build linux freebsd

package directory

Expand Down
2 changes: 1 addition & 1 deletion pkg/mount/flags_unsupported.go
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
// +build !linux,!freebsd freebsd,!cgo solaris,!cgo
// +build !linux,!freebsd freebsd,!cgo

package mount

Expand Down
2 changes: 1 addition & 1 deletion pkg/mount/mount.go
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ func GetMounts() ([]*Info, error) {
}

// Mounted determines if a specified mountpoint has been mounted.
// On Linux it looks at /proc/self/mountinfo and on Solaris at mnttab.
// On Linux it looks at /proc/self/mountinfo.
func Mounted(mountpoint string) (bool, error) {
entries, err := parseMountTable()
if err != nil {
Expand Down
2 changes: 1 addition & 1 deletion pkg/mount/mount_unix_test.go
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
// +build !windows,!solaris
// +build !windows

package mount

Expand Down
2 changes: 1 addition & 1 deletion pkg/mount/mounter_unsupported.go
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
// +build !linux,!freebsd,!solaris freebsd,!cgo solaris,!cgo
// +build !linux,!freebsd freebsd,!cgo

package mount

Expand Down
2 changes: 1 addition & 1 deletion pkg/mount/mountinfo_unsupported.go
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
// +build !windows,!linux,!freebsd,!solaris freebsd,!cgo solaris,!cgo
// +build !windows,!linux,!freebsd freebsd,!cgo

package mount

Expand Down
2 changes: 1 addition & 1 deletion pkg/parsers/kernel/kernel_unix.go
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
// +build linux freebsd solaris openbsd
// +build linux freebsd openbsd

// Package kernel provides helper function to get, parse and compare kernel
// versions for different platforms.
Expand Down
2 changes: 1 addition & 1 deletion pkg/parsers/kernel/uname_unsupported.go
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
// +build !linux,!solaris
// +build !linux

package kernel

Expand Down
2 changes: 1 addition & 1 deletion pkg/platform/architecture_unix.go
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
// +build freebsd solaris darwin
// +build freebsd darwin

// Package platform provides helper function to get the runtime architecture
// for different platforms.
Expand Down
2 changes: 1 addition & 1 deletion pkg/reexec/command_unix.go
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
// +build freebsd solaris darwin
// +build freebsd darwin

package reexec

Expand Down
Loading

0 comments on commit 4785f1a

Please sign in to comment.