Skip to content

Commit

Permalink
Merge pull request moby#41528 from thaJeztah/remove_default_oom_score…
Browse files Browse the repository at this point in the history
…_adj
  • Loading branch information
cpuguy83 committed Oct 16, 2020
2 parents bebbec4 + 561b801 commit e180525
Show file tree
Hide file tree
Showing 3 changed files with 10 additions and 1 deletion.
2 changes: 1 addition & 1 deletion cmd/dockerd/config_unix.go
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ func installConfigFlags(conf *config.Config, flags *pflag.FlagSet) error {
flags.StringVar(&conf.CgroupParent, "cgroup-parent", "", "Set parent cgroup for all containers")
flags.StringVar(&conf.RemappedRoot, "userns-remap", "", "User/Group setting for user namespaces")
flags.BoolVar(&conf.LiveRestoreEnabled, "live-restore", false, "Enable live restore of docker when containers are still running")
flags.IntVar(&conf.OOMScoreAdjust, "oom-score-adjust", -500, "Set the oom_score_adj for the daemon")
flags.IntVar(&conf.OOMScoreAdjust, "oom-score-adjust", 0, "Set the oom_score_adj for the daemon")
flags.BoolVar(&conf.Init, "init", false, "Run an init in the container to forward signals and reap processes")
flags.StringVar(&conf.InitPath, "init-path", "", "Path to the docker-init binary")
flags.Int64Var(&conf.CPURealtimePeriod, "cpu-rt-period", 0, "Limit the CPU real-time period in microseconds for the parent cgroup for all containers")
Expand Down
2 changes: 2 additions & 0 deletions testutil/daemon/daemon.go
Original file line number Diff line number Diff line change
Expand Up @@ -88,6 +88,7 @@ type Daemon struct {
DefaultAddrPool []string
SubnetSize uint32
DataPathPort uint32
OOMScoreAdjust int
// cached information
CachedInfo types.Info
}
Expand Down Expand Up @@ -206,6 +207,7 @@ func New(t testing.TB, ops ...Option) *Daemon {
}
ops = append(ops, WithRootlessUser("unprivilegeduser"))
}
ops = append(ops, WithOOMScoreAdjust(-500))

d, err := NewDaemon(dest, ops...)
assert.NilError(t, err, "could not create daemon at %q", dest)
Expand Down
7 changes: 7 additions & 0 deletions testutil/daemon/ops.go
Original file line number Diff line number Diff line change
Expand Up @@ -115,3 +115,10 @@ func WithRootlessUser(username string) Option {
d.rootlessUser = u
}
}

// WithOOMScoreAdjust sets OOM score for the daemon
func WithOOMScoreAdjust(score int) Option {
return func(d *Daemon) {
d.OOMScoreAdjust = score
}
}

0 comments on commit e180525

Please sign in to comment.