add support for custom collectors #307
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrismarget-j
requested changes
Aug 2, 2024
|
|
||
| cs, err := o.GetCollectorsByServiceName(ctx, in.ServiceName) | ||
| if err != nil { | ||
| return convertTtaeToAceWherePossible(err) |
There was a problem hiding this comment.
There shouldn't be any harm in invoking convertTtaeToAceWherePossible here, but it shouldn't be necessary. This code invoked a Client method, rather than talkToApstra(), so any error should already have been converted to a ClientErr.
chrismarget-j
requested changes
Aug 21, 2024
| @@ -474,6 +547,5 @@ func (o *RoutingZoneConstraintMode) FromString(s string) error { | |||
| if t == nil { | |||
| return fmt.Errorf("failed to parse RoutingZoneConstraintMode %q", s) | |||
| } | |||
| o.Value = t.Value | |||
There was a problem hiding this comment.
Looks like a line was deleted by mistake?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As previously discussed, this breaks out the Collectors as their own independent objects, hides some of the complexity of dealing with the API, giving a consistent CRUD interface.
There are some renaming and follow-up commits coming, but this outlines the logic that will be used.