Test probe only #923
Merged
Test probe only #923
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dantti
requested changes
Jan 17, 2024
dantti
reviewed
Jan 17, 2024
|
@ferdnyc would you fix the conflicts please. |
|
@winterz Sorry for the delay, will do. |
- Use inheritance to avoid repeating 'generator' and 'binaryDir' - Take advantage of 'inherits' feature that allows specifying a string, rather than a list, if inheriting only one config - Add configurations for ci-dev-probe-only-qt5 and -qt6.
- Also add additional workflow parameter 'matrix.config.tests_with', which is set to either 'qt5' or 'qt6' if tests should be run for a particular configuration. - Update unit test 'if:' parameters to use 'matrix.config.tests_with' - Only perform the "enable gdb attaching" steps if unit tests are going to be run. - Enable unit tests for client-and-ui builds
|
@winterz Done. I took the opportunity to squash some of the back-and-forth away, since I had to rewrite all of the commits to rebase the branch. |
|
the 2 CI failures are related to KDStateMachineEditor dependency which we're still working. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Way back in #765, I submitted some patches to fix the
GAMMARAY_CLIENT_ONLY_BUILD, which had stealth-broken because it wasn't being tested in CI.The same is now true of
GAMMARAY_PROBE_ONLY_BUILD, so to avoid the possibility of similar stealth breakage, this PR adds test runs for probe-only builds to the standard CI, by first adding configurations for them to theCMakePresets.json.Along the way, it makes some adjustments to the existing configuration(s), to facilitate adding additional CI build configurations
Presets file
CMakePresets.json"generator"or"binaryDir"when those can simply be inherited."inherits", rather than a list value, when only one configuration is being inherited from.(Not all configurations were adjusted, mostly just the ones I was touching anyway. But in both cases, they all could be changed the same way.)
CI configuration
build.ymlmatrix.config.tests_withvalue is optionally added to matrix members, set to eitherqt5orqt6.This allows the complicated version checks:
startsWith(matrix.config.qt_version, '6.')matrix.config.tests_with == 'qt6'runner.os) not only controls which tests are run, but its absence will prevent tests from being run at all. (Mostly because unit tests on aPROBE_ONLYbuild are simultaneously both pointless and redundant.)