Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add docs for enabling git symlinks (originally Repository build fails (Windows)) #426

Closed
2 tasks
uafcybs opened this issue Feb 1, 2023 · 17 comments · Fixed by #439
Closed
2 tasks

Add docs for enabling git symlinks (originally Repository build fails (Windows)) #426

uafcybs opened this issue Feb 1, 2023 · 17 comments · Fixed by #439
Labels
🪲 bug Something isn't working 📖 documentation Improvements or additions to documentation 🙋 good first issue Good for newcomers
Milestone

Comments

@uafcybs
Copy link

uafcybs commented Feb 1, 2023

Add documentation that git needs symlinks enabled for Windows otherwise errors occur.

  • Add to README
  • Add to book

Original description

I've been trying to build "out of the box" repository as suggested in the README file with trivial cmake commands.
It always failed for cargo_without_cmake project:
build_log.txt
Rust - 1.66.1
C++ - MS VS 2022
CMake - 3.24.3

Are there any other things to consider besides those listed in the README?
Thanks in advance

@uafcybs
Copy link
Author

uafcybs commented Feb 2, 2023 via email

@uafcybs
Copy link
Author

uafcybs commented Feb 2, 2023 via email

@Be-ing
Copy link
Contributor

Be-ing commented Feb 2, 2023

In addition to my last email – there are some files with Windows line endings:
moc_* files
*.h files in vcpgk

The build script doesn't analyze those files to generate code, so those are probably not relevant to this bug. Have you tried the suggested patch?

@Be-ing
Copy link
Contributor

Be-ing commented Feb 2, 2023

What version of Windows are you using? You may need to enable developer mode for the symlinks in this repository to work.

@uafcybs
Copy link
Author

uafcybs commented Feb 2, 2023 via email

@uafcybs
Copy link
Author

uafcybs commented Feb 2, 2023 via email

@vimpostor
Copy link
Member

Have you tried the suggested patch?

I realized find('\n') would also find the \n in \r\n and thus work correctly, so it's nothing with line endings after all (hence my deleted comment).
Would need to investigate closer with Windows, I can't see anything now that wouldn't work in Windows at a quick glance.

@Be-ing
Copy link
Contributor

Be-ing commented Feb 3, 2023

Enabling developer mode did not help …

Did you delete and re-clone this git repository after enabling developer mode?

@uafcybs
Copy link
Author

uafcybs commented Feb 3, 2023 via email

@uafcybs
Copy link
Author

uafcybs commented Feb 3, 2023

Enabling developer mode did not help …

Did you delete and re-clone this git repository after enabling developer mode?

Clear/re-clone did not help

@Be-ing
Copy link
Contributor

Be-ing commented Feb 4, 2023

What are the contents of the file cxx-qt/examples/cargo_without_cmake/src)/cxxqt_object.rs?

@Be-ing
Copy link
Contributor

Be-ing commented Feb 4, 2023

Make sure Git has symlinks enabled by running git config core.symlinks true

@uafcybs
Copy link
Author

uafcybs commented Feb 4, 2023

Make sure Git has symlinks enabled by running git config core.symlinks true

This helps, thank you!

@uafcybs uafcybs closed this as completed Feb 5, 2023
@uafcybs
Copy link
Author

uafcybs commented Feb 5, 2023

It might be helpful for some other Windows users to mention this symlink related stuff in the README.md.
It is also built out of the box only with --config Release in my case. With default (Debug) configuration the build ends up with lot of linker errors regarding the different debug info levels in object files/libraries.

@ahayzen-kdab
Copy link
Collaborator

I think it would be a good idea to note this somewhere in the README and/or book so lets re-open this issue to track that.

@ahayzen-kdab ahayzen-kdab reopened this Feb 6, 2023
@ahayzen-kdab ahayzen-kdab changed the title Repository build fails (Windows) Add docs for enabling git symlinks (originally Repository build fails (Windows)) Feb 6, 2023
@ahayzen-kdab ahayzen-kdab added 🪲 bug Something isn't working 📖 documentation Improvements or additions to documentation labels Feb 6, 2023
@ahayzen-kdab ahayzen-kdab added this to the 0.5 milestone Feb 6, 2023
@ahayzen-kdab ahayzen-kdab added the 🙋 good first issue Good for newcomers label Feb 6, 2023
@Be-ing
Copy link
Contributor

Be-ing commented Feb 6, 2023

It is also built out of the box only with --config Release in my case. With default (Debug) configuration the build ends up with lot of linker errors regarding the different debug info levels in object files/libraries.

rust-lang/cc-rs#717

@Be-ing
Copy link
Contributor

Be-ing commented Feb 11, 2023

I think it would be a good idea to note this somewhere in the README

I added that to the README here: #439

ahayzen-kdab pushed a commit to Be-ing/cxx-qt that referenced this issue Feb 13, 2023
przempore pushed a commit to przempore/cxx-qt that referenced this issue Mar 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🪲 bug Something isn't working 📖 documentation Improvements or additions to documentation 🙋 good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants