cmake: set MSVC_RUNTIME_LIBRARY to MultiThreadedDLL

[ahayzen-kdab]

Related to #682
Related to #676

[OlivierLDff]

Will it work for more complex projects? Because then you will have other targets linking to the default, and the app & rust lib to MultiThreadedDLL. Not sure if this is how it work.
I would recommend setting the global CMAKE_MSVC_RUNTIME_LIBRARY so every target do so.

[ahayzen-kdab]

Will it work for more complex projects? Because then you will have other targets linking to the default, and the app & rust lib to MultiThreadedDLL. Not sure if this is how it work. I would recommend setting the global CMAKE_MSVC_RUNTIME_LIBRARY so every target do so.

Can we set this in all of the example CMakeLists.txt's ? I know it's slightly pointless as it should come from the root and is effectively a noop. But we see people copy the CMakeList out of the example folder and then miss that there is something set globally. So i think there should be something in each of the projects too.

I'm also trying to fix my Windows setup so i can test some of this stuff myself 😅

[OlivierLDff]

Yes setting it in each example is a good idea, maybe with a warning that it would be best to set it in the command line.

[ahayzen-kdab]

This seems to work :-)

@OlivierLDff does the change look sane to you ?

[OlivierLDff]

Yes this is what is required for it to work out of the box.