Skip to content
This repository has been archived by the owner on Nov 24, 2022. It is now read-only.

SDK Compatibility #245

Merged
merged 7 commits into from
Jan 9, 2020
Merged

SDK Compatibility #245

merged 7 commits into from
Jan 9, 2020

Conversation

LeonFLK
Copy link
Contributor

@LeonFLK LeonFLK commented Dec 13, 2019

fixes https://github.com/KILTprotocol/ticket/issues/160

This is just replacing constructor calls of refactored constructors and changing property names accordingly.

I'll create a second ticket if we want to change our descriptions aswell hash to roothash and cType to cTypeHash.

Checklist:

  • I have verified that the code works
  • I have verified that the code is easy to understand
    • If not, I have left a well-balanced amount of inline comments
  • I have left the code in a better state
  • I have documented the changes (where applicable)

@tjwelde
Copy link
Contributor

tjwelde commented Jan 8, 2020

Here, we still use a fromObject method:

this.setState({ cType: CType.fromObject(cType) })

It might be too much for this PR, but this whole ctype class is a big annoyance for me:
export class CType implements ICType {

@tjwelde
Copy link
Contributor

tjwelde commented Jan 9, 2020

My last remarks will be fixed in #231

Copy link
Contributor

@tjwelde tjwelde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tjwelde tjwelde merged commit cc5e937 into develop Jan 9, 2020
@tjwelde tjwelde deleted the lw-159-sdk-compatibility branch January 9, 2020 17:23
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants