Skip to content
This repository has been archived by the owner on Nov 24, 2022. It is now read-only.

fix: take delegation id from request #254

Merged
merged 2 commits into from
Feb 18, 2020
Merged

fix: take delegation id from request #254

merged 2 commits into from
Feb 18, 2020

Conversation

tjwelde
Copy link
Contributor

@tjwelde tjwelde commented Feb 17, 2020 •
edited
Loading

fixes KILTprotocol/ticket#303

related to KILTprotocol/sdk-js#239

How to test:

Check the PR in the sdk-js repo

Checklist:

  • I have verified that the code works
  • I have verified that the code is easy to understand
    • If not, I have left a well-balanced amount of inline comments
  • I have left the code in a better state
  • I have documented the changes (where applicable)

maudnals
maudnals approved these changes Feb 18, 2020
View reviewed changes
Copy link
Contributor

@maudnals maudnals left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@tjwelde tjwelde merged commit b2caa4c into develop Feb 18, 2020
@tjwelde tjwelde deleted the hotfix/attestation-delegationid branch February 18, 2020 10:24
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@maudnals maudnals maudnals approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tjwelde @maudnals