Skip to content
This repository has been archived by the owner on Nov 24, 2022. It is now read-only.

feat: prepended protocol to URLs #255

Merged
merged 1 commit into from
Feb 18, 2020
Merged

feat: prepended protocol to URLs #255

merged 1 commit into from
Feb 18, 2020

Conversation

maudnals
Copy link
Contributor

@maudnals maudnals commented Feb 18, 2020 •
edited
Loading

Fixes KILTProtocol/ticket#317

Prepended HTTPS to BOTH REACT_APP_SERVICE_HOST and PUBLIC_URL.
Initially, the issues were caused by REACT_APP_SERVICE_HOST but I thought I might as well fix PUBLIC_URL too.

How to test:

Make sure that the build scripts run properly.

Checklist:

  • I have verified that the code works
  • I have verified that the code is easy to understand
    • If not, I have left a well-balanced amount of inline comments
  • I have left the code in a better state
  • I have documented the changes (where applicable)

tjwelde
tjwelde approved these changes Feb 18, 2020
View reviewed changes
Copy link
Contributor

@tjwelde tjwelde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tjwelde tjwelde merged commit cbcd752 into develop Feb 18, 2020
@tjwelde tjwelde deleted the mn-317-protocol-URL branch February 18, 2020 10:05
@tjwelde
Copy link
Contributor

tjwelde commented Feb 19, 2020

fixes https://github.com/KILTprotocol/ticket/issues/68

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@tjwelde tjwelde tjwelde approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@maudnals @tjwelde