Skip to content
This repository has been archived by the owner on Nov 24, 2022. It is now read-only.

refactor: quote compatibility #256

Merged
merged 3 commits into from
Mar 13, 2020
Merged

refactor: quote compatibility #256

merged 3 commits into from
Mar 13, 2020

Conversation

Dudleyneedham
Copy link
Member

@Dudleyneedham Dudleyneedham commented Feb 27, 2020 •
edited
Loading

fixes https://github.com/KILTprotocol/ticket/issues/347

Added all the changes from the SDK to the demo client regarding the Quote

How to test:

Pull and build with the develop branch from the SDK using yalc

Use the devTools and create cTypes and claims

Checklist:

  • I have verified that the code works
  • I have verified that the code is easy to understand
    • If not, I have left a well-balanced amount of inline comments
  • I have left the code in a better state
  • I have documented the changes (where applicable)

@Dudleyneedham Dudleyneedham changed the title refactor: quote compatibility WIP: refactor: quote compatibility Mar 12, 2020
tjwelde
tjwelde approved these changes Mar 13, 2020
View reviewed changes
Copy link
Contributor

@tjwelde tjwelde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Dudleyneedham Dudleyneedham changed the title WIP: refactor: quote compatibility refactor: quote compatibility Mar 13, 2020
@Dudleyneedham Dudleyneedham merged commit 5017d29 into develop Mar 13, 2020
@Dudleyneedham Dudleyneedham deleted the demo-347-quote-compat branch March 13, 2020 14:51
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@tjwelde tjwelde tjwelde approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Dudleyneedham @tjwelde