Skip to content
This repository has been archived by the owner on Nov 24, 2022. It is now read-only.

refactor: demo client production file updating #269

Merged
merged 1 commit into from
Jun 18, 2020

Conversation

Dudleyneedham
Copy link
Member

fixes https://github.com/KILTprotocol/ticket/issues/570

Updating the production file and blockchain services to match the new sdk-js version 0.18.0

How to test:

Run through all the tests and connect to the production nodes and services.

Checklist:

  • I have verified that the code works
  • I have verified that the code is easy to understand
    • If not, I have left a well-balanced amount of inline comments
  • I have left the code in a better state
  • I have documented the changes (where applicable)

@weichweich
Copy link

The docker compose needs to be updated too?

did not work when running demo client images locally
Copy link
Contributor

@LeonFLK LeonFLK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If this cover all the consumers of the service address:

LGTM

@Dudleyneedham Dudleyneedham merged commit 956e808 into develop Jun 18, 2020
@tjwelde tjwelde deleted the demo-release-ready branch September 23, 2020 14:45
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants