Skip to content
This repository has been archived by the owner on Nov 24, 2022. It is now read-only.

refactor: inclusion in prototype services readme #272

Merged
merged 2 commits into from
Jul 2, 2020

Conversation

Dudleyneedham
Copy link
Member

@Dudleyneedham Dudleyneedham commented Jul 2, 2020

fixes https://github.com/KILTprotocol/ticket/issues/607

Had a question inside the RIOT channel regarding the local setup.

Noticed there was no mention of the Prototype serivces.

How to test:

Let us think of stuff.

Checklist:

  • I have verified that the code works
  • I have verified that the code is easy to understand
    • If not, I have left a well-balanced amount of inline comments
  • I have left the code in a better state
  • I have documented the changes (where applicable)

Copy link

@wischli wischli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As discussed, we should change the default spin up to include the services in the future. But for now, this is fine.

@wischli wischli added the ❤️ High priority: high label Jul 2, 2020
@rflechtner
Copy link
Contributor

I wasn't aware the readme was so outdated. No mention of the docker-compose instructions (see our internal documentation). This could also help in improving the readme.

@Dudleyneedham
Copy link
Member Author

If you want to add somethings please do.

@rflechtner
Copy link
Contributor

As discussed, we should change the default spin up to include the services in the future. But for now, this is fine.

services are already included, just use docker-compose up

added instructions on how to use docker-compose
Copy link

@wischli wischli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good improvement!

@Dudleyneedham Dudleyneedham merged commit c4810cd into develop Jul 2, 2020
@Dudleyneedham Dudleyneedham deleted the demo-readme-update branch July 2, 2020 18:29
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
❤️ High priority: high
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants