Skip to content
This repository has been archived by the owner on Nov 24, 2022. It is now read-only.

fix: delegation root node bug when switching identities #280

Merged
merged 1 commit into from
Aug 5, 2020

Conversation

Dudleyneedham
Copy link
Member

fixes https://github.com/KILTprotocol/ticket/issues/620

When creating a Delegation root node switching accounts would not re-render the new account.

How to test:

Create a new delegation and switch accounts.

Checklist:

  • I have verified that the code works
  • I have verified that the code is easy to understand
    • If not, I have left a well-balanced amount of inline comments
  • I have left the code in a better state
  • I have documented the changes (where applicable)

Copy link
Contributor

@rflechtner rflechtner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works! As a suggestion: seems to me that we don't have to create & save a delegation in state before hitting the "submit" button (execting submit()). The whole switching identities process could be a lot leaner if we only create the delegation on submit and otherwise take the identity (owner) from the props.

@Dudleyneedham Dudleyneedham merged commit 19153b6 into develop Aug 5, 2020
@Dudleyneedham Dudleyneedham deleted the root-delegation-fix branch August 5, 2020 09:28
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants