This repository has been archived by the owner on Nov 24, 2022. It is now read-only.
Provide signed messageId when removing message by Id #286
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tjwelde
suggested changes
Sep 23, 2020
| (notification: IBlockingNotification) => { | ||
| MessageRepository.deleteByMessageId( | ||
| message.messageId as string, | ||
| selectedIdentity.identity.signStr(message.messageId as string) |
There was a problem hiding this comment.
If messageId is a number, you can apply toString instead of using as
There was a problem hiding this comment.
messageId is string | undefined
we previously returned on !messageId, now we check for existence and do a non-null assertion
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes KILTProtocol/ticket#734
Checklist: