Skip to content
This repository has been archived by the owner on Nov 24, 2022. It is now read-only.

Sign did with sdk when registering #287

Merged
merged 2 commits into from
Sep 23, 2020
Merged

Sign did with sdk when registering #287

merged 2 commits into from
Sep 23, 2020

Conversation

LeonFLK
Copy link
Contributor

@LeonFLK LeonFLK commented Sep 16, 2020

fixes KILTProtocol/ticket#736

Checklist:

  • I have verified that the code works
  • I have verified that the code is easy to understand
    • If not, I have left a well-balanced amount of inline comments
  • I have left the code in a better state
  • I have documented the changes (where applicable)

@LeonFLK LeonFLK self-assigned this Sep 23, 2020
tjwelde
tjwelde approved these changes Sep 23, 2020
View reviewed changes
Copy link
Contributor

@tjwelde tjwelde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@LeonFLK LeonFLK merged commit ff5f653 into develop Sep 23, 2020
@tjwelde tjwelde deleted the lw-736-sign-did branch September 23, 2020 14:45
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@tjwelde tjwelde tjwelde approved these changes

@Dudleyneedham Dudleyneedham Awaiting requested review from Dudleyneedham

Assignees

@LeonFLK LeonFLK

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@LeonFLK @tjwelde