Skip to content
This repository has been archived by the owner on Nov 24, 2022. It is now read-only.

fix: attestation check valid #289

Merged
merged 4 commits into from
Sep 23, 2020
Merged

fix: attestation check valid #289

merged 4 commits into from
Sep 23, 2020

Conversation

Dudleyneedham
Copy link
Member

fixes https://github.com/KILTprotocol/ticket/issues/745

Fixes the name of verify function from the sdk

Checklist:

  • I have verified that the code works
  • I have verified that the code is easy to understand
    • If not, I have left a well-balanced amount of inline comments
  • I have left the code in a better state
  • I have documented the changes (where applicable)

@Dudleyneedham Dudleyneedham self-assigned this Sep 23, 2020
@tjwelde tjwelde changed the title fix: Attestation check valid fix: attestation check valid Sep 23, 2020
tjwelde
tjwelde approved these changes Sep 23, 2020
View reviewed changes
Copy link
Contributor

@tjwelde tjwelde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Dudleyneedham Dudleyneedham merged commit 5029811 into develop Sep 23, 2020
@Dudleyneedham Dudleyneedham deleted the attestation-check-valid branch September 23, 2020 14:36
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@tjwelde tjwelde tjwelde approved these changes

@LeonFLK LeonFLK Awaiting requested review from LeonFLK

Assignees

@Dudleyneedham Dudleyneedham

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Dudleyneedham @tjwelde